mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rob@landley.net
Cc: linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
	ebiederm@xmission.com, xiyou.wangcong@gmail.com,
	yoshfuji@linux-ipv6.org, segoon@openwall.com
Subject: Re: [PATCH 1/1] Change ping_group_range default to what Android's init script sets.
Date: Tue, 31 Oct 2017 17:27:08 +0900 (KST)	[thread overview]
Message-ID: <20171031.172708.36762351833302595.davem@davemloft.net> (raw)
In-Reply-To: <29f9ee1d-7ad4-b4df-7202-35c66893cc16@landley.net>


Please CC: netdev@vger.kernel.org for all networking patches.  Asking
qustions on lkml about networking issues is unlikely to obtain a
response.

Also, instead of giving an external refernce to a web site discussion,
you must explain _in painful detail_ in your commit message the
reasons for making this change.  Just "Android does it this way" is
not an acceptable reason.

People should be able to read the commit message and completely
understand why a change was made.

Thanks.

  reply	other threads:[~2017-10-31  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  3:39 Rob Landley
2017-10-31  8:27 ` David Miller [this message]
2017-10-31 17:10 ` Randy Dunlap
2017-10-31 18:44 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031.172708.36762351833302595.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=segoon@openwall.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®