From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdJaIAA (ORCPT ); Tue, 31 Oct 2017 04:00:00 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:51436 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdJaH77 (ORCPT ); Tue, 31 Oct 2017 03:59:59 -0400 Date: Tue, 31 Oct 2017 15:59:25 +0800 From: Herbert Xu To: Gilad Ben-Yossef Cc: "David S. Miller" , Ofir Drang , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: testmgr: don't allocate IV on stack Message-ID: <20171031075925.GA26147@gondor.apana.org.au> References: <1509436586-17500-1-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509436586-17500-1-git-send-email-gilad@benyossef.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 07:56:26AM +0000, Gilad Ben-Yossef wrote: > The IV was allocated on the stack in testmgr skcipher tests. > Since HW based tfm providers need to DMA the IV to the HW, > this leads to problems and is detected by the DMA-API debug > code. > > Fix it by allocating the IV using kmalloc instead. > > Signed-off-by: Gilad Ben-Yossef The driver that is mapping the IV directly should be fixed instead. Only input that is given in the form of SG lists can be mapped. Everything else should be copied if they need to go over DMA. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt