From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932617AbdJaKT6 (ORCPT ); Tue, 31 Oct 2017 06:19:58 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:51606 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932362AbdJaKTp (ORCPT ); Tue, 31 Oct 2017 06:19:45 -0400 Date: Tue, 31 Oct 2017 18:19:08 +0800 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Gilad Ben-Yossef , "David S. Miller" , Ofir Drang , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] crypto: testmgr: don't allocate IV on stack Message-ID: <20171031101908.GA26530@gondor.apana.org.au> References: <1509436586-17500-1-git-send-email-gilad@benyossef.com> <20171031075925.GA26147@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 09:05:57AM +0000, Horia Geantă wrote: > > > > The driver that is mapping the IV directly should be fixed instead. > > Only input that is given in the form of SG lists can be mapped. > > Everything else should be copied if they need to go over DMA. > > > Herbert, wouldn't it make more sense to follow your previous suggestion: > "Perhaps we should change the API so that it gets passed in as an > SG list." > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg23082.html Unless someone is willing to work on that then we have to fix the drivers to fit the current API. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt