From: Jessica Yu <jeyu@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: module: Do not paper over type mismatches in module_param_call()
Date: Tue, 31 Oct 2017 15:46:04 +0100 [thread overview]
Message-ID: <20171031144604.svshm5sfkxy5m54a@redbean> (raw)
In-Reply-To: <CAGXu5jJWujShMJ4MM8bOyPrtDUTcfjH1_xufCWdbwS1hnb0Zsg@mail.gmail.com>
+++ Kees Cook [30/10/17 14:20 -0700]:
>On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook <keescook@chromium.org> wrote:
>> (re-sending to Jessica's @korg address...)
>>
>> The module_param_call() macro was explicitly casting the .set and .get
>> function prototypes away with (void *). This can lead to hard-to-find
>> type mismatches. Additionally, it creates problems for static checkers
>> and Control Flow Itegrity compiler features, which depend on clustering
>> function call sites based on prototype signature.
>>
>> This removes the casts and fixes all the incorrect prototypes tree-wide.
>
>A quick ping on this. I'd really like to land this in 4.15, as it's
>relatively trivial. How does this look to you Jessica?
Hey Kees!
Sorry for the delay, and thanks for fixing this up - had to dig deep
through git history to remind myself why these casts and that weird
compiler type-check were being done in the first place :-/ I guess
the original reason was backward compatibility.
Anyways I've pushed this to modules-next, thanks!
Jessica
prev parent reply other threads:[~2017-10-31 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 2:04 [RESEND][PATCH 0/3] " Kees Cook
2017-10-18 2:04 ` [PATCH 1/3] module: Prepare to convert all module_param_call() prototypes Kees Cook
2017-10-18 2:04 ` [PATCH 2/3] treewide: Fix function prototypes for module_param_call() Kees Cook
2017-10-18 2:04 ` [PATCH 3/3] module: Do not paper over type mismatches in module_param_call() Kees Cook
2017-10-18 10:12 ` [RESEND][PATCH 0/3] " Arnd Bergmann
2017-10-18 14:21 ` Kees Cook
2017-10-30 21:20 ` Kees Cook
2017-10-31 14:46 ` Jessica Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031144604.svshm5sfkxy5m54a@redbean \
--to=jeyu@kernel.org \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®