From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932667AbdJaV7d (ORCPT ); Tue, 31 Oct 2017 17:59:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:58212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932583AbdJaV7c (ORCPT ); Tue, 31 Oct 2017 17:59:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A4F21921 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 31 Oct 2017 17:59:28 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Zhou Chengming , Ingo Molnar , , , , , , , , , , , Subject: Re: [PATCH] kprobes, x86/alternatives: use text_mutex to protect smp_alt_modules Message-ID: <20171031175928.1d1d7a6b@gandalf.local.home> In-Reply-To: <20171030170323.12610b7d04e739e6cb4c4ec0@kernel.org> References: <1509096884-22993-1-git-send-email-zhouchengming1@huawei.com> <20171030170323.12610b7d04e739e6cb4c4ec0@kernel.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Oct 2017 17:03:23 +0900 Masami Hiramatsu wrote: > > static LIST_HEAD(smp_alt_modules); > > -static DEFINE_MUTEX(smp_alt); > > -static bool uniproc_patched = false; /* protected by smp_alt */ > > +static bool uniproc_patched = false; /* protected by text_mutex */ We should also add a comment somewhere by the text_mutex that it is protecting this on x86. -- Steve