From: Stephen Hemminger <stephen@networkplumber.org>
To: andreas.noever@gmail.com, michael.jamet@intel.com,
mika.westerberg@linux.intel.com, yehezkel.bernat@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Excessive logging in thunderbolt driver
Date: Tue, 31 Oct 2017 22:45:46 +0100 [thread overview]
Message-ID: <20171031224546.46ac6eab@shemminger-XPS-13-9360> (raw)
The thunderbolt driver needs to stop logging.
All these debug messages and the laptop is on battery with no devices connected.
(I did use a USB key, but that is not a thunderbolt device).
IMHO a production driver should log nothing in normal operation.
If you insist, the one message when device is found on discovery/probe
is allowed at INFO level.
All the rest should just go away, or be turned into pr_debug().
$ dmesg | grep thunderbolt
[ 28.979485] thunderbolt 0000:03:00.0: NHI initialized, starting thunderbolt
[ 28.979490] thunderbolt 0000:03:00.0: allocating TX ring 0 of size 10
[ 28.979518] thunderbolt 0000:03:00.0: allocating RX ring 0 of size 10
[ 28.979532] thunderbolt 0000:03:00.0: control channel created
[ 28.979533] thunderbolt 0000:03:00.0: control channel starting...
[ 28.979534] thunderbolt 0000:03:00.0: starting TX ring 0
[ 28.979541] thunderbolt 0000:03:00.0: enabling interrupt at register 0x38200 bit 0 (0x0 -> 0x1)
[ 28.979542] thunderbolt 0000:03:00.0: starting RX ring 0
[ 28.979549] thunderbolt 0000:03:00.0: enabling interrupt at register 0x38200 bit 12 (0x1 -> 0x1001)
[ 29.077877] thunderbolt 0000:03:00.0: current switch config:
[ 29.077880] thunderbolt 0000:03:00.0: Switch: 8086:1576 (Revision: 4, TB Version: 2)
[ 29.077882] thunderbolt 0000:03:00.0: Max Port Number: 11
[ 29.077882] thunderbolt 0000:03:00.0: Config:
[ 29.077884] thunderbolt 0000:03:00.0: Upstream Port Number: 5 Depth: 0 Route String: 0x0 Enabled: 1, PlugEventsDelay: 254ms
[ 29.077885] thunderbolt 0000:03:00.0: unknown1: 0x0 unknown4: 0x0
[ 29.089024] thunderbolt 0000:03:00.0: 0: uid: 0xd45fb028d06d00
[ 29.089427] thunderbolt 0000:03:00.0: Port 0: 8086:1576 (Revision: 4, TB Version: 1, Type: Port (0x1))
[ 29.089428] thunderbolt 0000:03:00.0: Max hop id (in/out): 7/7
[ 29.089429] thunderbolt 0000:03:00.0: Max counters: 8
[ 29.089430] thunderbolt 0000:03:00.0: NFC Credits: 0x800000
[ 29.089578] thunderbolt 0000:03:00.0: Port 1: 8086:1576 (Revision: 4, TB Version: 1, Type: Port (0x1))
[ 29.089579] thunderbolt 0000:03:00.0: Max hop id (in/out): 15/15
[ 29.089580] thunderbolt 0000:03:00.0: Max counters: 16
[ 29.089580] thunderbolt 0000:03:00.0: NFC Credits: 0x3c00000
[ 29.089724] thunderbolt 0000:03:00.0: Port 2: 8086:1576 (Revision: 4, TB Version: 1, Type: Port (0x1))
[ 29.089725] thunderbolt 0000:03:00.0: Max hop id (in/out): 15/15
[ 29.089726] thunderbolt 0000:03:00.0: Max counters: 16
[ 29.089727] thunderbolt 0000:03:00.0: NFC Credits: 0x3c00000
[ 29.089728] thunderbolt 0000:03:00.0: 0:3: disabled by eeprom
[ 29.089729] thunderbolt 0000:03:00.0: 0:4: disabled by eeprom
[ 29.089730] thunderbolt 0000:03:00.0: 0:5: disabled by eeprom
[ 29.089775] thunderbolt 0000:03:00.0: Port 6: 8086:1576 (Revision: 4, TB Version: 1, Type: PCIe (0x100101))
[ 29.089776] thunderbolt 0000:03:00.0: Max hop id (in/out): 8/8
[ 29.089776] thunderbolt 0000:03:00.0: Max counters: 2
[ 29.089777] thunderbolt 0000:03:00.0: NFC Credits: 0x800000
[ 29.089827] thunderbolt 0000:03:00.0: Port 7: 8086:1576 (Revision: 4, TB Version: 1, Type: PCIe (0x100101))
[ 29.089828] thunderbolt 0000:03:00.0: Max hop id (in/out): 8/8
[ 29.089828] thunderbolt 0000:03:00.0: Max counters: 2
[ 29.089829] thunderbolt 0000:03:00.0: NFC Credits: 0x800000
[ 29.089830] thunderbolt 0000:03:00.0: 0:8: disabled by eeprom
[ 29.089831] thunderbolt 0000:03:00.0: 0:9: disabled by eeprom
[ 29.089873] thunderbolt 0000:03:00.0: Port 10: 8086:1576 (Revision: 4, TB Version: 1, Type: DP/HDMI (0xe0101))
[ 29.089874] thunderbolt 0000:03:00.0: Max hop id (in/out): 9/9
[ 29.089875] thunderbolt 0000:03:00.0: Max counters: 2
[ 29.089875] thunderbolt 0000:03:00.0: NFC Credits: 0x1000000
[ 29.089876] thunderbolt 0000:03:00.0: 0:b: disabled by eeprom
[ 34.424927] thunderbolt 0000:03:00.0: stopping RX ring 0
[ 34.424938] thunderbolt 0000:03:00.0: disabling interrupt at register 0x38200 bit 12 (0xffffffff -> 0xffffefff)
[ 34.424947] thunderbolt 0000:03:00.0: stopping TX ring 0
[ 34.424954] thunderbolt 0000:03:00.0: disabling interrupt at register 0x38200 bit 0 (0xffffffff -> 0xfffffffe)
[ 34.424957] thunderbolt 0000:03:00.0: control channel stopped
[ 34.425330] thunderbolt 0000:03:00.0: freeing RX ring 0
[ 34.425342] thunderbolt 0000:03:00.0: freeing TX ring 0
[ 34.425351] thunderbolt 0000:03:00.0: shutdown
next reply other threads:[~2017-10-31 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:45 Stephen Hemminger [this message]
2017-11-01 7:41 ` Mika Westerberg
2017-11-06 19:27 ` Andreas Noever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031224546.46ac6eab@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®