From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754195AbdKADST (ORCPT ); Tue, 31 Oct 2017 23:18:19 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44754 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdKADSR (ORCPT ); Tue, 31 Oct 2017 23:18:17 -0400 Date: Wed, 01 Nov 2017 12:18:12 +0900 (KST) Message-Id: <20171101.121812.969003043230573555.davem@davemloft.net> To: bianpan2016@163.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, lipeng321@huawei.com, linyunsheng@huawei.com, yankejian@huawei.com, tklauser@distanz.ch, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hns: set correct return value From: David Miller In-Reply-To: <1509353401-2699-1-git-send-email-bianpan2016@163.com> References: <1509353401-2699-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 Oct 2017 20:18:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Date: Mon, 30 Oct 2017 16:50:01 +0800 > The function of_parse_phandle() returns a NULL pointer if it cannot > resolve a phandle property to a device_node pointer. In function > hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract > the error code. However, in this case, the extracted error code will > always be zero, which is unexpected. > > Signed-off-by: Pan Bian Applied.