From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933098AbdKAMUl (ORCPT ); Wed, 1 Nov 2017 08:20:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52986 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbdKAMUi (ORCPT ); Wed, 1 Nov 2017 08:20:38 -0400 Date: Wed, 01 Nov 2017 21:20:30 +0900 (KST) Message-Id: <20171101.212030.879951866741665289.davem@davemloft.net> To: colin.king@canonical.com Cc: LinoSanfilippo@gmx.de, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx From: David Miller In-Reply-To: <20171031100823.19733-1-colin.king@canonical.com> References: <20171031100823.19733-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Nov 2017 05:20:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 31 Oct 2017 10:08:23 +0000 > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: > > drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value > stored to 'idx' during its initialization is never read > > Signed-off-by: Colin Ian King Applied to net-next.