From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754664AbdKAM1a (ORCPT ); Wed, 1 Nov 2017 08:27:30 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53130 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754560AbdKAM12 (ORCPT ); Wed, 1 Nov 2017 08:27:28 -0400 Date: Wed, 01 Nov 2017 21:27:24 +0900 (KST) Message-Id: <20171101.212724.2093826633682146421.davem@davemloft.net> To: colin.king@canonical.com Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: remove redundant assignment to variable work_done From: David Miller In-Reply-To: <20171031142324.25740-1-colin.king@canonical.com> References: <20171031142324.25740-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Nov 2017 05:27:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 31 Oct 2017 14:23:24 +0000 > From: Colin Ian King > > Variable work_done is set to zero and this value is never read, instead > it is set to another value a few statements later. Remove the redundant > assignment. Cleans up clang warning: > > drivers/net/ethernet/cadence/macb_main.c:1221:2: warning: Value stored > to 'work_done' is never read > > Signed-off-by: Colin Ian King Applied.