From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908AbdKAIm1 (ORCPT ); Wed, 1 Nov 2017 04:42:27 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:44445 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdKAImX (ORCPT ); Wed, 1 Nov 2017 04:42:23 -0400 X-Google-Smtp-Source: ABhQp+TdqMZPeT3fR5/izmWV0F2S1fppw80nEpn2ijM4IJtAsi3/d4MyAfECJr0HggSzUwk4EIW+ig== Date: Wed, 1 Nov 2017 17:39:55 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , David Ahern , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH 0/7] perf tools: Small sample parsing speedup Message-ID: <20171101083955.GA25146@danjae.aot.lge.com> References: <20171031092947.19410-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171031092947.19410-1-jolsa@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Tue, Oct 31, 2017 at 10:29:40AM +0100, Jiri Olsa wrote: > hi, > sending small speedup fix for sample parsing code > and few assorted fixes. Nice work, for patch 1-5: Acked-by: Namhyung Kim But I'm not sure for patch 6 and 7 as tool and event arguments are passed to others consistently. Thanks, Namhyung > > Also available in: > https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > perf/fixes > > thanks, > jirka > > > --- > Jiri Olsa (7): > perf tools: Reset cursor arg instead of callchain_cursor > perf tools: Centralize perf_sample initialization > perf tools: Add perf_evlist__parse_sample_timestamp function > perf tools: Pass timestamp arg in perf_session__queue_event > perf tools: Optimize sample parsing for ordered events > perf tools: Remove perf_tool from event_op2 > perf tools: Remove perf_tool from event_op3 > > tools/perf/builtin-inject.c | 32 ++++++++++++++------------------ > tools/perf/builtin-kvm.c | 8 ++++---- > tools/perf/builtin-script.c | 22 ++++++++++------------ > tools/perf/builtin-stat.c | 23 +++++++++++------------ > tools/perf/util/auxtrace.c | 17 +++++++---------- > tools/perf/util/auxtrace.h | 15 ++++++--------- > tools/perf/util/evlist.c | 11 +++++++++++ > tools/perf/util/evlist.h | 4 ++++ > tools/perf/util/evsel.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------- > tools/perf/util/evsel.h | 4 ++++ > tools/perf/util/header.c | 16 +++++++--------- > tools/perf/util/header.h | 15 ++++++--------- > tools/perf/util/machine.c | 2 +- > tools/perf/util/ordered-events.c | 3 +-- > tools/perf/util/ordered-events.h | 2 +- > tools/perf/util/session.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------- > tools/perf/util/session.h | 7 +++---- > tools/perf/util/stat.c | 5 ++--- > tools/perf/util/stat.h | 5 ++--- > tools/perf/util/tool.h | 7 ++----- > 20 files changed, 208 insertions(+), 181 deletions(-)