From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbdKAJCW (ORCPT ); Wed, 1 Nov 2017 05:02:22 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:54836 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbdKAJCR (ORCPT ); Wed, 1 Nov 2017 05:02:17 -0400 X-Google-Smtp-Source: ABhQp+Sk/U7gMUgfXTXRUVQHYV/M9yZFBUw3pbUpWit/sPPQ65LRNDXrRJZZjNUT1m5H/XD1JzPDWw== Date: Wed, 1 Nov 2017 10:02:14 +0100 From: Daniel Vetter To: Kees Cook Cc: Patrik Jakobsson , LKML , Maling list - DRI developers Subject: Re: [PATCH] drm: gma500: Convert timers to use timer_setup() Message-ID: <20171101090213.eqelpqrfa4vwytch@phenom.ffwll.local> Mail-Followup-To: Kees Cook , Patrik Jakobsson , LKML , Maling list - DRI developers References: <20171024151609.GA104501@beast> <20171030100838.lvjxy3o6q227kjsn@phenom.ffwll.local> <20171031101835.npsnxjbf5ctlm66k@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 08:08:14AM -0700, Kees Cook wrote: > On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter wrote: > > On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote: > >> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: > >> > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote: > >> >> In preparation for unconditionally passing the struct timer_list pointer to > >> >> all timer callbacks, switch to using the new timer_setup() and from_timer() > >> >> to pass the timer pointer explicitly. > >> >> > >> >> Cc: Patrik Jakobsson > >> >> Cc: David Airlie > >> >> Cc: dri-devel@lists.freedesktop.org > >> >> Signed-off-by: Kees Cook > >> > > >> > Do you expect drm folks to apply this, or is this part of a larger refactoring? > >> > >> If the drm tree includes -rc3, you can carry these. If you don't want > >> to carry these and want the timer tree to carry them, we can do that > >> too. > > > > Applied to drm-misc-next for 4.16 (we're way past freeze for 4.15 > > already). > > Since this is one of the few remaining "non-trivial" users of the > ancient init_timer() API, would you mind if the timers tree carried > this for 4.15? I'm trying to entirely remove the init_timer() API (and > if I can, remove the old setup_*timer() API too). I was contemplating before applying it whether I should ask ... Oh well, problem is that drm-misc is non-rebasing, but you can just apply it twice. git usually figures it out. Acked-by: Daniel Vetter in case you do so. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch