From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbdKAJ1K (ORCPT ); Wed, 1 Nov 2017 05:27:10 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54929 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415AbdKAJ1G (ORCPT ); Wed, 1 Nov 2017 05:27:06 -0400 X-Google-Smtp-Source: ABhQp+Qba+7cJQSuiTNa5/1PhSmX/GnlM65kqap1kDjHqU5jDwrKEzzrrPa2eoOsVIE/gMn3hq7rJA== Date: Wed, 1 Nov 2017 09:27:03 +0000 From: Lee Jones To: Baolin Wang Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH v4 2/2] mfd: Add Spreadtrum SC27xx series PMICs driver Message-ID: <20171101092703.i5t7ejuhcs45cchw@dell> References: <0806380ab2674f78f925b9015e558ffb634f11f1.1509503569.git.baolin.wang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0806380ab2674f78f925b9015e558ffb634f11f1.1509503569.git.baolin.wang@spreadtrum.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Nov 2017, Baolin Wang wrote: > This patch adds support for Spreadtrum SC27xx series PMIC MFD core, and It > provides communication through the SPI interfaces. The SC27xx series PMICs > contains the following 6 major components: > - DCDCs > - LDOs > - Battery management system > - Audio codec > - User interface function, such as indicator, flash LED > - IC level function, such as power on/off, type-c > > Signed-off-by: Baolin Wang > --- > Changes since v3: > - Use memcpy() to copy register offset address into SPI buffer. > > Changes since v2: > - Add more help information. > - Define macros for irq base and irq number. > - Use devm_mfd_add_devices() instead of mfd_add_devices(), which means > we can remove sprd_pmic_remove(). > - Rename local variables in sprd_pmic_probe(). > > Changes since v1: > - Add more documentation to introduce Spreadtrum SC27xx series PMICs. > - Modify compatile string property. > - Modify reg property. > - Remove redundant 'pmic' label. > - Change 'should be' to 'must be' for cells properties. > --- > drivers/mfd/Kconfig | 16 +++ > drivers/mfd/Makefile | 1 + > drivers/mfd/sprd-sc27xx-spi.c | 259 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 276 insertions(+) > create mode 100644 drivers/mfd/sprd-sc27xx-spi.c Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog