From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754504AbdKAK4e (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 06:56:34 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:44452 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752254AbdKAK4c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 06:56:32 -0400
X-Google-Smtp-Source: ABhQp+TmwNN0MXdzGIoeQAvNkoBBmY6xlXrxSlyt09WPHFNZqHtGOq5Ks2wxMJWUkR+spwZDH+wnkg==
Date: Wed, 1 Nov 2017 13:56:29 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>, moritz.lipp@iaik.tugraz.at,
        daniel.gruss@iaik.tugraz.at, michael.schwarz@iaik.tugraz.at,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@google.com>, Hugh Dickins <hughd@google.com>,
        X86 ML <x86@kernel.org>
Subject: Re: [PATCH 04/23] x86, tlb: make CR4-based TLB flushes more robust
Message-ID: <20171101105629.xne4hbivhu6ex3bx@node.shutemov.name>
References: <20171031223146.6B47C861@viggo.jf.intel.com>
 <20171031223154.67F15B2A@viggo.jf.intel.com>
 <CALCETrW06XjaWYD1O_HPXPDrHS96FZz9=OkPCQ3vsKrAxnr8+A@mail.gmail.com>
 <20171101101147.x2gvag62zpzydgr3@node.shutemov.name>
 <CALCETrVhKwGPN-=sL5SoSg1ussO+oCfzH1cJ+ZSWb69Y51XjXg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrVhKwGPN-=sL5SoSg1ussO+oCfzH1cJ+ZSWb69Y51XjXg@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 01, 2017 at 03:38:23AM -0700, Andy Lutomirski wrote:
> On Wed, Nov 1, 2017 at 3:11 AM, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> > On Wed, Nov 01, 2017 at 01:01:45AM -0700, Andy Lutomirski wrote:
> >> On Tue, Oct 31, 2017 at 3:31 PM, Dave Hansen
> >> <dave.hansen@linux.intel.com> wrote:
> >> >
> >> > Our CR4-based TLB flush currently requries global pages to be
> >> > supported *and* enabled.  But, we really only need for them to be
> >> > supported.  Make the code more robust by alllowing X86_CR4_PGE to
> >> > clear as well as set.
> >> >
> >> > This change was suggested by Kirill Shutemov.
> >>
> >> I may have missed something, but why would be ever have CR4.PGE off?
> >
> > This came out from me thinking on if we can disable global pages by not
> > turning on CR4.PGE instead of making _PAGE_GLOBAL zero.
> >
> > Dave decided to not take this path, but this change would make
> > __native_flush_tlb_global_irq_disabled() a bit less fragile in case
> > if the situation would change in the future.
> 
> How about just adding a VM_WARN_ON_ONCE, then?

What's wrong with xor? The function will continue to work this way even if
CR4.PGE is disabled.

-- 
 Kirill A. Shutemov