From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754251AbdKAEXp (ORCPT ); Wed, 1 Nov 2017 00:23:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:39518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbdKAEXo (ORCPT ); Wed, 1 Nov 2017 00:23:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF34A21871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Wed, 1 Nov 2017 13:23:40 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, Tom Zanussi , Rajvi Jingar Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail Message-Id: <20171101132340.f700f0081419897798a4b1f3@kernel.org> In-Reply-To: <20171031174432.770bd509@gandalf.local.home> References: <150946150188.23534.2733334352688090372.stgit@devbox> <20171031174432.770bd509@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Oct 2017 17:44:32 -0400 Steven Rostedt wrote: > On Tue, 31 Oct 2017 23:51:42 +0900 > Masami Hiramatsu wrote: > > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > index 74507db8bbc8..b8701fa0b8f2 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > > @@ -8,7 +8,7 @@ echo > kprobe_events > > echo p:myevent _do_fork > kprobe_events > > test -d events/kprobes/myevent > > echo 1 > events/kprobes/myevent/enable > > -echo > kprobe_events && exit 1 # this must fail > > +echo > kprobe_events && exit_fail > > Should we keep the comment about "this must fail", otherwise it may > look like a mistake. Echoing in kprobe_events returns failure here? Ah, good catch! I misread the comment is for "exit 1"... Thank you, > > -- Steve > > > > echo 0 > events/kprobes/myevent/enable > > echo > kprobe_events # this must succeed > > clear_trace -- Masami Hiramatsu