From: Joel Stanley <joel@jms.id.au>
To: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh+dt@kernel.org>
Cc: Philipp Zabel <philipp.zabel@gmail.com>,
Mykola Kostenok <c_mykolak@mellanox.com>,
Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>,
Patrick Venture <venture@google.com>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] hwmon: Add reset support to aspeed-pwm-tach
Date: Thu, 2 Nov 2017 14:53:46 +1100 [thread overview]
Message-ID: <20171102035349.1902-1-joel@jms.id.au> (raw)
Gunter,
This adds reset controller support to the ASPEED pwm/tach driver. The reset
controller and clock driver is currently under review, so to test those patches
must be merged in to fully test these changes[1].
To address your concerns from v1:
This driver was not usable as-is upstream. I believe the developer(s) tested and
deployed it in the OpenBMC kernel tree which has some hacks in mach-aspeed to
release all of the resets. The other way they could have tested it is by
booting an OpenBMC kernel, which releases the resets, and then testing the
upstream kernel without performing a power cycle as the resets are not
reasserted on reboot.
I realise it is not ideal to be changing already merged bindings. I don't plan
on it becoming a habit.
There is no BIOS or other ROM that runs before Linux on a BMC to release
the resets. We do have u-boot, but that does not modify the pwm reset.
I haven't added a Kconfig dependency on the RESET_CONTROLLER as the driver can
build without it, and when the ASPEED clk/reset driver is merged, the platform
will always have that option selected.
I've given this version a day of testing on hardware I have access to.
[1] https://lwn.net/Articles/737697/
Joel Stanley (3):
hwmon: (aspeed-pwm-tacho) Sort headers
hwmon: (aspeed-pwm-tacho) Deassert reset in probe
dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node
.../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 14 ++++-------
drivers/hwmon/aspeed-pwm-tacho.c | 27 +++++++++++++++++++---
2 files changed, 29 insertions(+), 12 deletions(-)
--
2.14.1
next reply other threads:[~2017-11-02 3:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 3:53 Joel Stanley [this message]
2017-11-02 3:53 ` [PATCH v2 1/3] hwmon: (aspeed-pwm-tacho) Sort headers Joel Stanley
2017-11-04 18:09 ` [v2,1/3] " Guenter Roeck
2017-11-02 3:53 ` [PATCH v2 2/3] hwmon: (aspeed-pwm-tacho) Deassert reset in probe Joel Stanley
2017-11-02 14:54 ` Guenter Roeck
2017-11-03 2:32 ` Joel Stanley
2017-11-03 10:11 ` Guenter Roeck
2017-12-03 18:58 ` [v2,2/3] " Guenter Roeck
2017-11-02 3:53 ` [PATCH v2 3/3] dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node Joel Stanley
2017-11-06 21:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102035349.1902-1-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=c_mykolak@mellanox.com \
--cc=devicetree@vger.kernel.org \
--cc=jaghu@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=philipp.zabel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®