From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbdKBEs3 (ORCPT ); Thu, 2 Nov 2017 00:48:29 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:47575 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbdKBEs1 (ORCPT ); Thu, 2 Nov 2017 00:48:27 -0400 X-Google-Smtp-Source: ABhQp+SSuS4rijCJM6r+b0F6QQIHNYvdppTlGfRaEvkPf0n4UPX27iBOC/WjbfBVBBQx/ukUsCMKLA== Date: Thu, 2 Nov 2017 10:18:23 +0530 From: Viresh Kumar To: Rob Herring Cc: Frank Rowand , Vincent Guittot , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] of: platform: Create dummy routines for !CONFIG_OF_ADDRESS Message-ID: <20171102044823.GV4240@vireshk-i7> References: <2d798213e4fefc074a66ccb7ab2fc243ee2b1e1a.1509186356.git.viresh.kumar@linaro.org> <20171101211458.wo4at67k7sxo5fah@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171101211458.wo4at67k7sxo5fah@rob-hp-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-11-17, 16:14, Rob Herring wrote: > On Sat, Oct 28, 2017 at 03:56:46PM +0530, Viresh Kumar wrote: > > Few routines don't have their dummy counterparts which results in build > > failures where these routines are used without CONFIG_OF_ADDRESS > > enabled. > > > > Fix those by defining the dummy versions. > > > > Signed-off-by: Viresh Kumar > > --- > > V2: > > - Rebased again latest rc and resolved conflicts. > > - No comments received on V1. > > What's your user? It was the previous version of boot constraint core, though I have moved to another helper now. https://marc.info/?l=linux-kernel&m=150157976217258&w=2 Wouldn't it be better to define them anyway? -- viresh