From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933371AbdKBLRi (ORCPT ); Thu, 2 Nov 2017 07:17:38 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:55197 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933128AbdKBLRg (ORCPT ); Thu, 2 Nov 2017 07:17:36 -0400 From: Arnd Bergmann To: Mark Brown Cc: Arnd Bergmann , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Maxime Coquelin , Alexandre Torgue , Olivier Moysan , Dan Carpenter , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: stm32: sai: attempt to fix uninitialized variable Date: Thu, 2 Nov 2017 12:15:48 +0100 Message-Id: <20171102111620.3688534-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ykv4fy/v4UHt1TS67Iul7AS7pQVmlrrjIcxUdB22w52CIfzXILn Gopvn9jUebMozxt40nyDEjkaLr4hR5l86xAb6ZSsxs+eDzT61Tj/91Nc6F1rkxiZkR4DNjN AyUn57cuF4T10LMh3zp3qwl+sagBpMdhk8ry88AEd4R59wn9n192p0AoYgsNTPnC8OtMH5/ 2VfK+KJ63EtK8PkcRbddA== X-UI-Out-Filterresults: notjunk:1;V01:K0:MYnGNnTDVJc=:d7Rnd1LFq1RdziuZRfaYOl TBeSUYrqJIUy8F9sORnv+nN6ehiL5zfQaQ3Tk2SXTJQHtgxRvC6PWxSAm5fLQr0u1X0F7xEaC yyGQoRb1Htps84qnvbcuouwirLlNgoYDClOG8s5fRH+TSw7BsuEg+qeYFS1PxYHeSO831MKm+ DwCM/y1OIGpa+KtEeHrLmjTqEp+r0V833qxlCagXhrI3ec+7R6Zjapn71pZZ9todhEJDo/RPD 4zOEjtWkTjOu9QnfOGcbmj+kkaF5tWGFH3LM2O+V0tN/JkGYq4TdmZBXfUK1n03L4clrwLp09 nDBz9J+qosZS08ChZXgDXW5PBHh7xmdsInq1a6/UwxkxjvDV3k9RVfRx6IesmkfsZWJRzy/z8 UrUEkzq8/Uk3grKGKjJtDZl+P2TjoACtpRbyhmFcntfZE52ey+bcO7x9bDCQXnUg9CSCmndpz /+6uPNtASYPXwgKY/QR8XBBjmVC5hn1jZ1kH/XPvSI0IG8050cctSKNg6lO8/mdXTYBzX/yqF 5RppqsXpE3EOyZJL8Jj6BF/H0erp0vEuwJGpSH5IUi+iYvrbLnijt67F9Cjp2jGjhOaiKFxFh LcUWmuFZdlpJYP9TUBmpHr7Xfs4izu+r7S2Uhs6uvw6ormBLfJwPhgOoLD1SmyXF79YSu5SJT DkOvXdHSiIrHYxVUpZFSz1c+vz7tf17SYtuxcAcYc1vHjhiMXb164S2KYjkIz8pmjVSyTnLt4 s44/OKjM0STPN6WMQsPEzzGa0By6jKzjRYnAzA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 61fb4ff70377 ("ASoC: stm32: sai: Move static settings to DAI init"), we get a valid warning about the use of an uninitialized variable: sound/soc/stm/stm32_sai_sub.c: In function 'stm32_sai_hw_params': sound/soc/stm/stm32_sai_sub.c:485:7: error: 'cr1' may be used uninitialized in this function [-Werror=maybe-uninitialized] I could not immediately figure out what the code should do instead, this is the hack I applied locally to shut up the warning. It may or may not be correct, please take a look. Fixes: 61fb4ff70377 ("ASoC: stm32: sai: Move static settings to DAI init") Signed-off-by: Arnd Bergmann --- sound/soc/stm/stm32_sai_sub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 150ad546d8b9..d8a51fce368a 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -480,6 +480,7 @@ static int stm32_sai_set_config(struct snd_soc_dai *cpu_dai, /* Mode, data format and channel config */ cr1_mask = SAI_XCR1_DS_MASK; + cr1 = 0; switch (params_format(params)) { case SNDRV_PCM_FORMAT_S8: cr1 |= SAI_XCR1_DS_SET(SAI_DATASIZE_8); -- 2.9.0