From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753664AbdKBL4a (ORCPT ); Thu, 2 Nov 2017 07:56:30 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:33727 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdKBL43 (ORCPT ); Thu, 2 Nov 2017 07:56:29 -0400 Date: Thu, 2 Nov 2017 12:56:27 +0100 From: Boris Brezillon To: Arnd Bergmann Cc: Eric Anholt , David Airlie , Daniel Vetter , Cihangir Akturk , Dave Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: use %z format string for size_t Message-ID: <20171102125627.45a19fd7@bbrezillon> In-Reply-To: <20171102112107.4058917-1-arnd@arndb.de> References: <20171102112107.4058917-1-arnd@arndb.de> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, 2 Nov 2017 12:20:43 +0100 Arnd Bergmann wrote: > Printing a size_t variable needs to use the %z format string modifier > rather than %l, otherwise we get this warning on 64-bit architectures: > > drivers/gpu/drm/vc4/vc4_bo.c: In function 'vc4_bo_stats_debugfs': > drivers/gpu/drm/vc4/vc4_bo.c:91:26: error: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Werror=format=] > I already sent (and applied) a fix for this bug [1]. Regards, Boris [1]https://patchwork.kernel.org/patch/10036075/ > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c > index 3c3d11236910..4ae45d7dac42 100644 > --- a/drivers/gpu/drm/vc4/vc4_bo.c > +++ b/drivers/gpu/drm/vc4/vc4_bo.c > @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused) > > mutex_lock(&vc4->purgeable.lock); > if (vc4->purgeable.num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache", > vc4->purgeable.size / 1024, vc4->purgeable.num); > > if (vc4->purgeable.purged_num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO", > vc4->purgeable.purged_size / 1024, > vc4->purgeable.purged_num); > mutex_unlock(&vc4->purgeable.lock);