From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933880AbdKBPSS (ORCPT ); Thu, 2 Nov 2017 11:18:18 -0400 Received: from 10.mo68.mail-out.ovh.net ([46.105.79.203]:43065 "EHLO 10.mo68.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933767AbdKBPSG (ORCPT ); Thu, 2 Nov 2017 11:18:06 -0400 From: Andi Shyti To: Dmitry Torokhov Cc: Michael Hennerich , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH 1/5] Input: ad7897 - use managed devm_kzalloc Date: Thu, 2 Nov 2017 17:01:32 +0200 Message-Id: <20171102150136.1476-2-andi@etezian.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171102150136.1476-1-andi@etezian.org> References: <20171102150136.1476-1-andi@etezian.org> X-Ovh-Tracer-Id: 3705899544571069082 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrgeeigdeilecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allocate the driver's structure by using devm_kzalloc instead of simple kzalloc and remove all the related kfree calls. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 0381c7809d1b..68941b72ed8a 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -707,9 +707,9 @@ static int ad7877_probe(struct spi_device *spi) return err; } - ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL); + ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL); input_dev = input_allocate_device(); - if (!ts || !input_dev) { + if (!input_dev) { err = -ENOMEM; goto err_free_mem; } @@ -799,7 +799,6 @@ static int ad7877_probe(struct spi_device *spi) free_irq(spi->irq, ts); err_free_mem: input_free_device(input_dev); - kfree(ts); return err; } @@ -813,7 +812,6 @@ static int ad7877_remove(struct spi_device *spi) free_irq(ts->spi->irq, ts); input_unregister_device(ts->input); - kfree(ts); dev_dbg(&spi->dev, "unregistered touchscreen\n"); -- 2.15.0