From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933766AbdKBPIZ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Nov 2017 11:08:25 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:30289 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933540AbdKBPIX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Nov 2017 11:08:23 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171102150821epoutp03d05ce81c345f42b28e1b3223911b27ec~zTU76Gnl02640926409epoutp03n
X-AuditID: b6c32a4b-eebff70000001126-dc-59fb34e5b01d
Mime-Version: 1.0
Subject: Re: [PATCH] zswap: Same-filled pages handling
Reply-To: srividya.dr@samsung.com
From: Srividya Desireddy <srividya.dr@samsung.com>
To: "sjenning@redhat.com" <sjenning@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Timofey Titovets <nefelim4ag@gmail.com>
CC: "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "penberg@kernel.org" <penberg@kernel.org>,
        Dinakar Reddy Pathireddy <dinakar.p@samsung.com>,
        SHARAN ALLUR <sharan.allur@samsung.com>,
        RAJIB BASU <rajib.basu@samsung.com>, JUHUN KIM <juhunkim@samsung.com>,
        "srividya.desireddy@gmail.com" <srividya.desireddy@gmail.com>
X-Priority: 3
X-Content-Kind-Code: NORMAL
In-Reply-To: <20171019010841.GA17308@bombadil.infradead.org>
X-Drm-Type: N,general
X-EPLocale: en_US.EUC-KR
X-EPWebmail-Msg-Type: personal
X-Msg-Generator: Mail
X-Msg-Type: PERSONAL
X-Reply-Demand: N
Message-ID: <20171102150820epcms5p307052ef7697592b3b4e2848bf4968f7b@epcms5p3>
Date: Thu, 02 Nov 2017 15:08:20 +0000
X-CMS-MailID: 20171102150820epcms5p307052ef7697592b3b4e2848bf4968f7b
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-CPGSPASS: Y
X-CPGSPASS: Y
X-MTR: 20171102150820epcms5p307052ef7697592b3b4e2848bf4968f7b
CMS-TYPE: 105P
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsWy7bCmhu5Tk9+RBlsWs1q8PKRpsbvjBKPF
        6W+nWS0u75rDZnFvzX9Wi9vP1jNbtH3+x2ox6+ckNosly9YyW+y6+ITN4tzMZkaL3z/msDnw
        eOycdZfdY/MKLY9NqzrZPDZ9msTu8X7fVTaPvi2rGD0+b5ILYI/isklJzcksSy3St0vgyjiz
        TahgF3vFsdUbWRoYl7B2MXJySAiYSGyZuo2li5GLQ0hgN6PErmXP2boYOTh4BQQl/u4QBqkR
        FjCT+H6ziRnEFhJQlGju3sAIETeR2PRvARNIOZuAkcTh8zkgY0QEGhglJlzuYgJxmAWamCW6
        t31khljGKzGj/SkLhC0tsX35VrBBnAI2Ep+a+6BqRCVurn7LDmFLSKxeCHIPiC0nMe3rGria
        98fmM0LYIhKt985CxQUlHvzcDRWvlOj4vBjqSSmJu98OgD0pIbCNUWLS5JVMEInljBL37kAV
        mUu8fXkQLM4r4Cux9lEb2CAWAVWJ9onroepdJN6tuQkWZxaQl9j+dg4zyPfMApoS63fpw/zY
        sPE3OybbVuLc/j3MEK18Er2/nzBNYFSdhQjqWUiGzkIYuoCReRWjZGpBcW56arFpgXFearle
        cWJucWleul5yfu4mRnCi0vLewbjpnM8hRgEORiUe3gPqvyKFWBPLiitzDzFKcDArifC+l/od
        KcSbklhZlVqUH19UmpNafIhRmoNFSZz32M7SSCGB9MSS1OzU1ILUIpgsEwenFDAuK4z/rKpw
        3WB+KnJHwL9qkcpN4U8cGWQMHhytWq505UVYglzCP9Pp8W4fmd79YFOM/28dqJ+iEtxkcSXz
        wqJ1ocVvpzC7yPNozNERzXMU/qTOwXq26+P13M5VFV8Uqg/b7Tov4HpTKfZs5FrZz10vOk21
        bz88diaJy+5O1GZfkV95buv7apRYijMSDbWYi4oTAYC8nxpQAwAA
X-CMS-RootMailID: 20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0
X-RootMTR: 20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0
References: <20171019010841.GA17308@bombadil.infradead.org>
        <20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
        <CAGqmi75Y9wbwBS0ZythcNF1gi6bW7g_XcuMDgLu=Nx4=pWC8Jw@mail.gmail.com>
        <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p3>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 
On Wed, Oct 19, 2017 at 6:38 AM, Matthew Wilcox wrote: 
> On Thu, Oct 19, 2017 at 12:31:18AM +0300, Timofey Titovets wrote:
>> > +static void zswap_fill_page(void *ptr, unsigned long value)
>> > +{
>> > +       unsigned int pos;
>> > +       unsigned long *page;
>> > +
>> > +       page = (unsigned long *)ptr;
>> > +       if (value == 0)
>> > +               memset(page, 0, PAGE_SIZE);
>> > +       else {
>> > +               for (pos = 0; pos < PAGE_SIZE / sizeof(*page); pos++)
>> > +                       page[pos] = value;
>> > +       }
>> > +}
>> 
>> Same here, but with memcpy().
>
>No.  Use memset_l which is optimised for this specific job.

I have tested this patch using memset_l() function in zswap_fill_page() on 
x86 64-bit system with 2GB RAM. The performance remains same. 
But, memset_l() funcion might be optimised in future. 
@Seth Jennings/Dan Streetman:  Should I use memset_l() function in this patch.