From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934259AbdKBQv4 (ORCPT ); Thu, 2 Nov 2017 12:51:56 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:38662 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933328AbdKBQvx (ORCPT ); Thu, 2 Nov 2017 12:51:53 -0400 Date: Thu, 2 Nov 2017 12:51:31 -0400 From: Roman Gushchin To: Alexei Starovoitov CC: , Tejun Heo , Alexei Starovoitov , Daniel Borkmann , , Subject: Re: [PATCH v2 net-next 3/5] bpf, cgroup: implement eBPF-based device controller for cgroup v2 Message-ID: <20171102165127.GA13892@castle.DHCP.thefacebook.com> References: <20171102145440.12986-1-guro@fb.com> <20171102145440.12986-4-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c091:200::2:53d6] X-ClientProxiedBy: DM5PR06CA0094.namprd06.prod.outlook.com (2603:10b6:4:3a::35) To DM3PR15MB1084.namprd15.prod.outlook.com (2603:10b6:0:12::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44f49308-f46b-43b6-6993-08d52211faf2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DM3PR15MB1084; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;3:/8fRPhqCNnbktRb+0aS+nP2GYZaACpm2Kt/gFnufF+euJcyM/cmMtxlsa7uVCx9yTMU65z6zQDc01AXIQJZRyZXYrqUk5tuQH/56AjKd3i3kSHbsWDT9kRs2rJTjN7KBY0Qi44M6nNexTXtJS6t0krYL59vMDKnGqOYtrjSDJtIWro/ia7YsdD8KMXRlm5CjaAeUlomnMI7QaZkdLqkQqGKZmhszi5KdGdSa6S1HHN676Az0SHaFRIZcfggc/mDg;25:6wbF/xt6y69tjP1CKELpm9FbjfCip0NSisxY7tLpb5qpwvbClbI6UkzbNzUw733pN4HKFjx4PtVOuglNGnOTLi+E4YSAC50CeOmljZLFATWqT/7HKm7LGpwyydkwMUuKLn2aK8aLc4dz0h7Uh2KMl7oFptafUOf3gMf6d6UuAZGrfFek4kMH2okPO4NWlolSNfAxpkPuHvNBc3QIpDqCqNfPoHQ2Ivgl4VCCbiti8HoFETd+kfAvg4seFZ331mSPKLVvjcbySyA+g8Te/0H4ZAYkYK1OKwrCnc2poIBLgTCbnqcKkJYo2dA2gPlViNKQUq+T9KBWM2FiJCzZ7S6r9A==;31:P91ZyGcDdmaOZvaegDTg7COcNtx5RdthB3dGlno+UiLQw5VpfkvhBcsgxkr/giFV5mptGxS5eFkrXkCJSk08cohhpM4BD4LB9J6ESI9292xVTm4+LgVe3g/z2bZjoGbhuISuZNyksFmJelmFvXcU1Fs/fCp7bokstdZx0I97AEnTP1RwU0g/M/W/XD2cb6EIPlwG6mPrBiVRJFGYzzGP/qJCvJUa0ie2/W/j3kdng1Q= X-MS-TrafficTypeDiagnostic: DM3PR15MB1084: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:Cj/xJopQrcjOJKPZrcPIWWco/NoFYcFQEQXvJvud41/uH9yE5d3edmWKpVE5J2GVIajETK+dxlKP3MRvn4L0fC/XWVDRipHuh74Y36LSLCRgRn7QvIYaNEKeBH/A98xrrkbFwTWUxfVIDL/JsbEe7seiZ3PPxJLblnLlxno+TVTWa4lfOVsNDiOiJ1hjRBXvl9yVUSgLh5ruZkxXJriSAZ+AmZ//IJCbKupje4eQ1Ftok2HOf9Ny218AjWp2kWH8vZrPc6SFzHJjCfJYiOA9gff3K5ywC7x4QdIy9WHqIJzgeUjnaXPpinIWI7pbxQZSCLwkXzIG4wwDxWYsP2w4Bbrsn2VLLuGS2FN5TWb0PwH/Q6oJhunUQL0lztJqiCq1XCWArtYCSNlmzJSAmzcW3KqloWpvdBzROvbCRC0XiD3QUmlod8UvFf5PhB2kzPgNHL6XEp5OH7BLscRGrgqZm64KvDxf3XQDGNgs01V/SlVWiF7IX/d/jAPEN9XRlG6R;4:HnUcMyyp05Wgjf1+PlN/5UKFWof6Vfdb59bkHvZ+kXrAunEIBvYz8AH9zvzLKW/wXtrIwoBeF7GGbEVILt6Vy8bkS6+BZJ/CTNCrAlmhUdb1JVpVyhnT9CDt/+EWOjMDjdzUXH+grQfqdafdh/WIp+4WewkPKuwggWqXAwBhvIbuUNZ6ta0iXTgmQjVg6kwgpTCEIeszVAhZETT88BSE4cZ79uFc1XFcCs2XAjxlv9VAO2wl2o0nEvUkwFZVTCtlc1RFho1l7KapnWnDOrawrA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3231020)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM3PR15MB1084;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM3PR15MB1084; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(346002)(376002)(199003)(189002)(24454002)(316002)(2906002)(83506002)(16586007)(53546010)(2950100002)(55016002)(54906003)(6636002)(58126008)(305945005)(50466002)(81166006)(6666003)(5660300001)(8676002)(8936002)(7736002)(86362001)(81156014)(9686003)(47776003)(105586002)(101416001)(478600001)(189998001)(33656002)(229853002)(68736007)(25786009)(4326008)(6246003)(50986999)(6116002)(97736004)(23726003)(106356001)(6506006)(53936002)(1076002)(6862004)(54356999)(76176999)(18370500001)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1084;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1084;23:EKv//YiuPsB2kuDtMjGCGB1LL0SVYKrfYc0sNN9pO?= =?us-ascii?Q?XhtiHzFpZRDwDewB8bt4arzVa/t874+L48ZHXv6V20dgFB+tfe9WViCKhBMp?= =?us-ascii?Q?jMoY3Z910gaAseOqT/7LviGP9SxZBpKHMKGV8rmAjlaRU1DvvpjuiCn4L0Vx?= =?us-ascii?Q?0fHfRzdh+Dey9gBlvoCYBDiGFEYZv6j8770OH500CPhUZgQxoe5ihSDpUfZI?= =?us-ascii?Q?MkLWMDJt8lMqS5QjkYaIatHaJBRlbVNoyp/R5BSAMpzoGC2mLLRqDLG4aXMx?= =?us-ascii?Q?G/+s/tilfKAWvgHT4XoGTi9ixrRQxdafGPWc+GPY4PkcFImhR/i8TvJUe+5n?= =?us-ascii?Q?BAC+xOu1F9f+mzBjmEwDQDav5FK4plUCU2F8Dm4sd+YBdz+SfsFIGvE8SBL4?= =?us-ascii?Q?FlD5XfbpsbaCx1XvHx0NEkL/KlBnVnNQIHqb2FvLz0zL5JAy6NlYnRLZ5qIw?= =?us-ascii?Q?bffns1KGNzBIjOeRHNSVwKrzd5POlsS1MSm3oVWvnG7yv7ilApyG3lb1L71m?= =?us-ascii?Q?MOT/TN2tWi5shSnFLwUV7qdccseQ3F0njf0DPjvSmbL+4soAY0otjlgydHzb?= =?us-ascii?Q?XvxppbRM5/AoMyCEy4+Lz8DhKqyzFT7la8CPCEXKDpIumLMkkw/Oi3GKzia6?= =?us-ascii?Q?RT4sh8FB3fjU4zsPLRIlhlz7W+zEKB46HrLhppOGGM2EhDK3qMOnOnQtmDOh?= =?us-ascii?Q?so52Chj4gem6dNgm/t00yVM3v7Z5DBgOm7ZBrLA+FQRY9cxJBnCE7PhGOTL8?= =?us-ascii?Q?sm38+8PaZLunzqGxHk1OmGFeJ8nyEmS/65JS+ntxJqI5KNIkk5Q1Wfjh26GY?= =?us-ascii?Q?0Ner2KabjHTs8lJqjeAyLXDdscN2WKWniFIsf2xrqi4yKoVrML4swqoM7OMR?= =?us-ascii?Q?LVowgs97zTTl0GQpohgXvROay09u7/27tKOT59fVcPWK197hgHi7Hdkhg/7k?= =?us-ascii?Q?sc+b5EkDsAcKUFdCj02FXpr5X3VnmRa0jUaeQr0KkwZIGHMzR1XMo442fSCA?= =?us-ascii?Q?m8qhIF7dXGdYeqZ2yOHqwZrELgs+LsOpEQKDpRXIaPZvwOnUTeqKn6S3jktO?= =?us-ascii?Q?1kfKHjOTtu3SHwGVk6K7fHAgXtRdzMDTYfOtQOe2UE2RgcEikHZ8sv+DS8Qy?= =?us-ascii?Q?uyexBG2ezUbPjb5Hw2rlNFeAL2v2HnZ+qfqZI7Mll82QNPrxkyzQ12qByRB4?= =?us-ascii?Q?D+5nJz0RB+VLr1R1JpK48IXYsfp6hYcLRLIhM7sJDj5LqwAZ3Yp3uoK+Q0dx?= =?us-ascii?Q?xTZAliFyrAbvd1DeVpmCrLbl5hFEFKezWmzWOI76Z9tUx440W2D1bVf6d35N?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;6:KShZnRiESvvPQwgGr7iDedNhliUeARACJJWbNejnXg0hgQKBETVW+8AfvP01pKNS0hRZOntMvK6AL88hhF/dr2omax7YyQThMQggC/nKV2N6wcG9jgQRRlary+YJlaU5ZAokj0Fma+ZMY/dQmso6WZxTiOlLQAQdq4IuBId9T3eB6777RzjxA2TAIe73kjXQN67jLm0MWjbbZdFu09/dFOab9ErccuXDnJuDeNExc2O5zW1V0tgdWTn4SBPF8/OYgcDcir9BCarSIHU5GvX6xLBMdxrW14aEckBA4ARHGfNO0lZssI6PRSRm1BtHyjMucwPkrQUm94ALaSSTKyoWgbBiCM0juUzXuPYuARlzosg=;5:cX4BNMCqoJbkingvp2jeF7v8wtZCxM/0HOA0Fc4jyS58bSBy8ch9g54X0BWvkjIDpn6nu/JmKkzdY/lcuc5Aatq+rvLFjhj1VHxPz9B0FQ11oJq3twMB5UyoJgkfdO6SFq6hEGnziduMlF+yrPFCPXYEoDVktAIZVS9mInQCTaI=;24:bHzWLjriBwsVTCylNdszZS8mwDOUx7wzWpNA05j3bFMDGZsilLSprRU8wBD9YwJC4B4/YtZJtJ+V5qXEfOlSzcMZj/9ZJwx9QaqB+J83Tnk=;7:ECud18+ZKxLNZwgguCTsmW9JrFEtlM16iY3uSSY/piTaiFf0ZgEW0F0RC1u7mDN5FpKxpTuEOwHrkiwXY/XgOpsCpOa8vFve8HJUzGeVnFNIBQCEZD29dKYhwn6DyX6aqsUJLREW5xg/ckOTwHYBFf9zXeJREpC72vkCLhYCFfy9GJqgP1elkRw3KIXa1NYFKbmRZkogbKFDbVu5Rw3258f7LCqmOWtN9dOHbiPmUItSBSQTLnJvMMMCluHnTnP0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:f//Cyue8KsLwMKNJMunFHHjSed5p5E9Sy9SOeHHyJF6V97KlBkxgTjXBGOY9nw0nKLO0aLEqeMcNxlwMRxrF0HJUhgfOQg1mTYJV88DGwptXt5vOJvEfBCHv28+znB3AhgVDpYluq0fEp4Pj0X/xiyddkxwGM020Z+OslqUU5GE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 16:51:35.4172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44f49308-f46b-43b6-6993-08d52211faf2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1084 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-02_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2017 at 08:11:07AM -0700, Alexei Starovoitov wrote: > On 11/2/17 7:54 AM, Roman Gushchin wrote: > > +#define DEV_BPF_ACC_MKNOD (1ULL << 0) > > +#define DEV_BPF_ACC_READ (1ULL << 1) > > +#define DEV_BPF_ACC_WRITE (1ULL << 2) > > + > > +#define DEV_BPF_DEV_BLOCK (1ULL << 0) > > +#define DEV_BPF_DEV_CHAR (1ULL << 1) > > + > > all macros in bpf.h start with BPF_ > To be consistent with the rest can you rename above to BPF_DEVCG_.. ? Sure. Will post v3.