From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
ckeepax@opensource.cirrus.com, tony@atomide.com,
ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com,
andy.shevchenko@gmail.com, alcooperx@gmail.com,
bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH v2 2/2] pinctrl: Allow indicating loss of pin states during low-power
Date: Thu, 2 Nov 2017 16:15:51 -0700 [thread overview]
Message-ID: <20171102231551.16220-3-f.fainelli@gmail.com> (raw)
In-Reply-To: <20171102231551.16220-1-f.fainelli@gmail.com>
Some platforms (e.g: Broadcom STB: BMIPS_GENERIC/ARCH_BRCMSTB) will lose
their register contents when entering their lower power state. In such a
case, the pinctrl-single driver that is used will not be able to restore
the power states without telling the core about it and having
pinctrl_select_state() check for that.
This patch adds a new optional boolean property that Device Tree can
define in order to obtain exactly that and having the core pinctrl code
take that into account.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 4 ++++
drivers/pinctrl/core.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
index ad9bbbba36e9..cc9bae3b7c33 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
@@ -103,6 +103,10 @@ Optional properties:
#pinctrl-cells: Number of pin control cells in addition to the index within the
pin controller device instance
+low-power-state-loss: boolean property which indicates that the pins lose their
+state during low power modes and therefore need to be restored upon system
+resumption.
+
Pin controller devices should contain the pin configuration nodes that client
devices reference.
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index c91359d48aa1..3fee457999b5 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1978,6 +1978,9 @@ pinctrl_init_controller(struct pinctrl_desc *pctldesc, struct device *dev,
pctldev->dev = dev;
mutex_init(&pctldev->mutex);
+ if (of_property_read_bool(dev->of_node, "low-power-state-loss"))
+ pctldev->flags |= PINCTRL_FLG_FORCE_STATE;
+
/* check core ops for sanity */
ret = pinctrl_check_ops(pctldev);
if (ret) {
--
2.9.3
next prev parent reply other threads:[~2017-11-02 23:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 23:15 [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Florian Fainelli
2017-11-02 23:15 ` [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state Florian Fainelli
2017-11-29 13:06 ` Linus Walleij
2017-11-29 17:01 ` Tony Lindgren
2017-11-29 17:35 ` Florian Fainelli
2017-11-29 17:45 ` Tony Lindgren
2017-11-29 18:15 ` Florian Fainelli
2017-11-29 18:27 ` Tony Lindgren
2017-11-02 23:15 ` Florian Fainelli [this message]
2017-11-29 13:01 ` [PATCH v2 2/2] pinctrl: Allow indicating loss of pin states during low-power Linus Walleij
2017-11-29 17:02 ` Tony Lindgren
2017-11-29 17:37 ` Florian Fainelli
2017-12-02 12:48 ` Linus Walleij
2017-12-10 23:38 ` Florian Fainelli
2017-12-20 7:24 ` Linus Walleij
2017-12-30 19:31 ` Florian Fainelli
2017-11-03 10:37 ` [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Charles Keepax
2017-11-03 16:11 ` Tony Lindgren
2017-11-03 17:02 ` Florian Fainelli
2017-11-03 17:33 ` Tony Lindgren
2017-11-04 8:37 ` Charles Keepax
2017-11-07 16:00 ` Tony Lindgren
2017-11-04 12:25 ` Rafael J. Wysocki
2017-11-04 17:19 ` Florian Fainelli
2017-11-07 16:00 ` Tony Lindgren
2017-11-08 0:23 ` Rafael J. Wysocki
2017-11-08 0:28 ` Florian Fainelli
2017-11-08 0:45 ` Rafael J. Wysocki
2017-11-08 1:04 ` Tony Lindgren
2017-11-08 1:02 ` Tony Lindgren
2017-11-03 17:03 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102231551.16220-3-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®