From: SeongJae Park <sj38.park@gmail.com>
To: paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, rostedt@goodmis.org
Cc: shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
SeongJae Park <sj38.park@gmail.com>
Subject: [PATCH 1/9] rcutorture/configinit: Fix build directory error message
Date: Fri, 3 Nov 2017 19:17:20 +0900 [thread overview]
Message-ID: <20171103101728.28288-2-sj38.park@gmail.com> (raw)
In-Reply-To: <20171103101728.28288-1-sj38.park@gmail.com>
'configinit.sh' checks format of optional argument for build directory
and print error message if the format is not valid. However, the error
message is broken so that it just says user entered empty string as
build directory even though user entered wrong, but non-empty string as
the argument. This commit fixes the message to show what user entered
for the argument.
Fixes: c87b9c601ac8 ("rcutorture: Add KVM-based test framework")
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/rcutorture/bin/configinit.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/rcutorture/bin/configinit.sh b/tools/testing/selftests/rcutorture/bin/configinit.sh
index 3f81a1095206..50a6371b2b2e 100755
--- a/tools/testing/selftests/rcutorture/bin/configinit.sh
+++ b/tools/testing/selftests/rcutorture/bin/configinit.sh
@@ -51,7 +51,7 @@ then
mkdir $builddir
fi
else
- echo Bad build directory: \"$builddir\"
+ echo Bad build directory: \"$buildloc\"
exit 2
fi
fi
--
2.13.0
next prev parent reply other threads:[~2017-11-03 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:17 [PATCH 0/9] Trivial fixup for KVM-based rcutorture test framework SeongJae Park
2017-11-03 10:17 ` SeongJae Park [this message]
2017-11-03 10:17 ` [PATCH 2/9] rcutorture: Remove unused script, config2frag.sh SeongJae Park
2017-11-03 10:17 ` [PATCH 3/9] rcutorture/kvm.sh: Remove unused variable, `alldone` SeongJae Park
2017-11-03 10:17 ` [PATCH 4/9] rcutorture/kvm.sh: Use consistent usage for --qemu-args SeongJae Park
2017-11-03 10:17 ` [PATCH 5/9] rcutorture/kvm.sh: Support execution from any directory SeongJae Park
2017-11-03 10:17 ` [PATCH 6/9] rcutorture/kvm-recheck-*: Improve result directory readability check SeongJae Park
2017-11-03 10:17 ` [PATCH 7/9] rcutorture/kvm-build.sh: Skip build directory check SeongJae Park
2017-11-03 10:17 ` [PATCH 8/9] rcutorture: Simplify logging SeongJae Park
2017-11-03 10:17 ` [PATCH 9/9] rcutorture: Simplify functions.sh include path SeongJae Park
2017-11-03 17:59 ` [PATCH 0/9] Trivial fixup for KVM-based rcutorture test framework Paul E. McKenney
2017-11-03 18:43 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103101728.28288-2-sj38.park@gmail.com \
--to=sj38.park@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®