From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933678AbdKCRr5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 13:47:57 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:59150 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932321AbdKCRr4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 13:47:56 -0400
Date: Fri, 3 Nov 2017 10:47:55 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Support resetting WARN_ONCE for all architectures
Message-Id: <20171103104755.0fa2dba59f48df43d5bffb25@linux-foundation.org>
In-Reply-To: <878tfn7ldw.fsf@concordia.ellerman.id.au>
References: <20171019204642.7404-1-andi@firstfloor.org>
        <878tfn7ldw.fsf@concordia.ellerman.id.au>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 03 Nov 2017 20:38:03 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:

> Hi Andi,
> 
> Thanks for making it work with the flag, but ...
> 
> Andi Kleen <andi@firstfloor.org> writes:
> > diff --git a/lib/bug.c b/lib/bug.c
> > index a6a1137d06db..7cb2d41845f7 100644
> > --- a/lib/bug.c
> > +++ b/lib/bug.c
> > @@ -195,3 +195,24 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
> >  
> >  	return BUG_TRAP_TYPE_BUG;
> >  }
> > +
> > +static void clear_once_table(struct bug_entry *start, struct bug_entry *end)
> > +{
> > +	struct bug_entry *bug;
> > +
> > +	for (bug = start; bug < end; bug++)
> > +		bug->flags &= ~BUGFLAG_ONCE;
> 
> Clearing BUGFLAG_ONCE removes the once-ness permanently. ie. it becomes
> a WARN().
> 
> You should be clearing BUGFLAG_DONE, which is the flag that says this
> WARN has already triggered.

This?

--- a/lib/bug.c~support-resetting-warn_once-for-all-architectures-v2-fix-fix-fix
+++ a/lib/bug.c
@@ -202,7 +202,7 @@ static void clear_once_table(struct bug_
 	struct bug_entry *bug;
 
 	for (bug = start; bug < end; bug++)
-		bug->flags &= ~BUGFLAG_ONCE;
+		bug->flags &= ~BUGFLAG_DONE;
 }
 
 void generic_bug_clear_once(void)


And this is getting a bit nutty:

support-resetting-warn_once.patch
support-resetting-warn_once-checkpatch-fixes.patch
support-resetting-warn_once-for-all-architectures.patch
support-resetting-warn_once-for-all-architectures-v2.patch
support-resetting-warn_once-for-all-architectures-v2-fix.patch
support-resetting-warn_once-for-all-architectures-v2-fix-fix.patch
support-resetting-warn_once-for-all-architectures-v2-fix-fix-fix.patch

I'll push all this at Stephen later today.  Someone please tell me
whether this code actually works!