From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952AbdKCO27 (ORCPT ); Fri, 3 Nov 2017 10:28:59 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:38376 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbdKCO25 (ORCPT ); Fri, 3 Nov 2017 10:28:57 -0400 Date: Fri, 3 Nov 2017 22:28:29 +0800 From: Herbert Xu To: Romain Izard Cc: "David S . Miller" , Tudor Ambarus , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Fixes for the Atmel AES crypto module Message-ID: <20171103142829.GT9011@gondor.apana.org.au> References: <20171031152524.25216-1-romain.izard.pro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031152524.25216-1-romain.izard.pro@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 04:25:22PM +0100, Romain Izard wrote: > After encountering an issue with cts(cbc(aes)) in the Atmel AES module, > I have used tcrypt and libkcapi's test suite to validate my fix. This led > me to observe some other issues. > > This series includes the IV issue correction for the Atmel AES crypto > engine, as well as a secondary issue observed when running > 'insmod tcrypt.ko mode=10' and 'insmod tcrypt.ko mode=152' on a SAMA5D2 > board. > > The libkcapi test suite still reports some problems, for example when the > input data is too large to fit into an intermediate buffer in unaligned > cases. And it seems that with the v4.14 updates, new asynchronous tests > are enabled and report new issues. > > Romain Izard (2): > crypto: atmel-aes - properly set IV after {en,de}crypt > crypto: atmel-aes - Reset the controller before each use > > drivers/crypto/atmel-aes.c | 50 ++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 40 insertions(+), 10 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt