From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756546AbdKCULQ (ORCPT ); Fri, 3 Nov 2017 16:11:16 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:34708 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756352AbdKCULN (ORCPT ); Fri, 3 Nov 2017 16:11:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3351:3622:3653:3865:3867:3868:3870:3873:5007:6261:7875:10004:10400:10848:10967:11232:11657:11658:11914:12043:12740:12760:12895:13069:13149:13230:13311:13357:13439:14181:14659:14721:21080:21627:30036:30054:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: drink94_7ec47a175e54b X-Filterd-Recvd-Size: 1553 Date: Fri, 3 Nov 2017 16:11:09 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, Tom Zanussi , Rajvi Jingar Subject: Re: [PATCH v2] selftests/ftrace: Introduce exit_pass and exit_fail Message-ID: <20171103161109.7848f3c3@vmware.local.home> In-Reply-To: <150973792087.3711.441163463778665781.stgit@devbox> References: <150973792087.3711.441163463778665781.stgit@devbox> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Nov 2017 04:38:41 +0900 Masami Hiramatsu wrote: > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -222,7 +222,14 @@ SIG_RESULT= > SIG_BASE=36 # Use realtime signals > SIG_PID=$$ > > +exit_pass () { > + exit 0 > +} > + > SIG_FAIL=$((SIG_BASE + FAIL)) > +exit_fail () { > + exit 1 Sorry, I should have caught this before. But can you use $PASS and $FAIL in the functions? In case we want to override them in the future? exit_pass() { exit $PASS } exit_fail() { exit $FAIL } -- Steve