From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279AbdKCTSC (ORCPT ); Fri, 3 Nov 2017 15:18:02 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:49273 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbdKCTSA (ORCPT ); Fri, 3 Nov 2017 15:18:00 -0400 X-Google-Smtp-Source: ABhQp+T1qDv57cI4L5WlRahs4ooSFprqkR7ELJHt+ewAZXnQTmiKsn5xwhOgUj3FuRmDrHm44ur3cg== Date: Fri, 3 Nov 2017 12:17:56 -0700 From: Dmitry Torokhov To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW Message-ID: <20171103191756.jee5272ml2lfgcvx@dtor-ws> References: <20171103190329.15194-1-stefan.bruens@rwth-aachen.de> <8c454b54-98a7-492d-b861-83d125306f86@rwthex-w2-a.rwth-ad.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c454b54-98a7-492d-b861-83d125306f86@rwthex-w2-a.rwth-ad.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 08:03:26PM +0100, Stefan Brüns wrote: > Sync events are sent by sparse_keymap_report_entry for normal KEY_* > events, and are generated by several drivers after generating > SW_* events, so sparse_keymap_report_entry should do the same. > > Without the sync, events are accumulated in the kernel. > > Currently, no driver uses sparse-keymap for SW_* events, but > it is required for the intel-vbtn platform driver to generate > SW_TABLET_MODE events. > > Signed-off-by: Stefan Brüns Applied, thank you. > --- > > drivers/input/sparse-keymap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c > index bb0349fa64bc..fd03e55768c9 100644 > --- a/drivers/input/sparse-keymap.c > +++ b/drivers/input/sparse-keymap.c > @@ -255,6 +255,7 @@ void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *k > > case KE_VSW: > input_report_switch(dev, ke->sw.code, value); > + input_sync(dev); > break; > } > } > -- > 2.14.3 > -- Dmitry