From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755728AbdKCUSf (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 16:18:35 -0400
Received: from mail-io0-f171.google.com ([209.85.223.171]:45170 "EHLO
        mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752114AbdKCUSb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 16:18:31 -0400
X-Google-Smtp-Source: ABhQp+SIuRQbO7W1dgW/kljbqKFAU5oIFSskvf73O0WYziIHJQKvSJQyyZKHyTjDjlsOv/JAlA6g4w==
Date: Fri, 3 Nov 2017 13:18:23 -0700
From: Sami Tolvanen <samitolvanen@google.com>
To: Kees Cook <keescook@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Greg Hackmann <ghackmann@google.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/15] arm64: use -mno-implicit-float instead of
 -mgeneral-regs-only
Message-ID: <20171103201823.GB137924@samitolvanen.mtv.corp.google.com>
References: <20171103171203.107569-1-samitolvanen@google.com>
 <20171103171203.107569-9-samitolvanen@google.com>
 <20171103183156.ando3jj5pl2hfk5j@lakrids.cambridge.arm.com>
 <20171103185222.k3c5kjo5m7dqieyg@lakrids.cambridge.arm.com>
 <CAGXu5jLAb+Jj7x8p0mizewoOHuQVqup9DxHkvgqkQFeB5cJo9w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5jLAb+Jj7x8p0mizewoOHuQVqup9DxHkvgqkQFeB5cJo9w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 03, 2017 at 12:06:15PM -0700, Kees Cook wrote:
> Should a clang version test be included, since we know at least 5.0 is
> need (with this fix)? There are distros with much earlier versions of
> clang, for example...

Greg knows better, but I remember him mentioning that upstream clang
doesn't generate any worse code with -mno-implicit-float, so there should
be no harm in using this workaround with all versions.

This might change in future, of course, so I don't have objections to
adding a check for clang version < 6.0 here.

Sami