From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbdKCWtB (ORCPT ); Fri, 3 Nov 2017 18:49:01 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52706 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbdKCWs7 (ORCPT ); Fri, 3 Nov 2017 18:48:59 -0400 From: Arnd Bergmann To: Jens Axboe , Bart Van Assche Cc: Arnd Bergmann , Hannes Reinecke , Thomas Gleixner , Shaohua Li , "Martin K. Petersen" , linux-kernel@vger.kernel.org Subject: [PATCH] cdrom: always select BLK_SCSI_REQUEST Date: Fri, 3 Nov 2017 23:48:17 +0100 Message-Id: <20171103224833.3921968-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:EybDKXZNjgSey7xdV92vXOEXeUshWSiY/fpJ57rHQqbEgj0W3sq oXzabsu7+8z6EQAlGKuRH7uPui1Ft0PYnufKkatmv5mVmUiCIpiT5YTwFzUXlY/0YRWgp7l l8TsJ9jKmbgrrlr2bv8DmoiARtCrtzHyyL5pnE7frkqWWjibngnt+UulLlOQqB5cUNQI+qF Laz9YjD3TcsjPq2muSduA== X-UI-Out-Filterresults: notjunk:1;V01:K0:cfsOUH4NTfU=:mUBlwtuFjxkjMw51UTBSq/ G77ryNbo0/oI1PpeVkmAoPjZAj7qal9a2izL6tFnbwvGD6Dch1M6qoQdW4tlqJfLmFZ2Lrg9I STqQq3nNPgV752nxfK9mxfu+MAnR5Gev49tOrTW7xxwxV9V8DRnPbZmilUaMlhSYw0BPMDFAq JgUeGZCoRiqppr8uobuzkbWdVcQf6zKP20XZDRfYp0SF95nOiuFoGje+Og7RfoNRspShz6jH2 1Vbxsn4kqIYDJ8KwRNF4OGxn1F/lCXQtl3SMAPFZy0D/Q0Jr5Aii38WarWFQETpqyQBJj6agb 086HVygwl2DetotZn5ebGDOryIIOPgSHSuoQZtW+jTvrsZthadP4d8NZc/fRGqfu7+0gTeVXc IQMprsOVXjN7b3bHLrAXyraKVmTFc9Z3PhVh7BtZGMnzTwPmnFqo+qqUdLLa41QyzfsqxYLF0 hWazSbv3ynZ5j3wp3+2+gTwvzhA2rE66dTw5DQvRohRGEz6aXUNDCY6pjADCUqa8lYBNemELb PNs2Dxy+3/ns3IG+sX+it1LHGEBNUi6SrLl7+VgdckDgPiluROkok2TGDJTx1ZVByHo0HbHr5 TK0T4SxT6PX4QFxnVl/3jj9wOIhBttOco4DRMtEQf6Cyb9pE36lFN7BrYggYw9XJDg/laYIWo p2L2c2rea5O4KzUIxCd8oryTHMXSi/9bEE2XD8hM2e7AfS1yzd9squvqOxqxXjSDnj6aXax0v AvER8TczYFf0GaLi2Rguh1l47JVmaFgBcKFtDQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CDROM is enabled, but nothing else selects BLK_SCSI_REQUEST, we get this link error: cdrom.c:(.text+0x7a18): undefined reference to `scsi_cmd_blk_ioctl' The problem is that the CDROM helper code has become user-selectable now when it used to only be compiled if anything else enabled it. This moves the 'select BLK_SCSI_REQUEST' from the drivers that explicitly have it into CONFIG_CDROM, to make sure we always build that code. Fixes: 2a750166a5be ("block: Rework drivers/cdrom/Makefile") Signed-off-by: Arnd Bergmann --- drivers/block/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index e84432df1a55..b8d9fcbe4020 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -69,7 +69,8 @@ config AMIGA_Z2RAM module will be called z2ram. config CDROM - tristate "CD-ROM driver" + tristate + select BLK_SCSI_REQUEST help A CD-ROM is a pre-pressed optical compact disc which contains data. The name is an acronym which stands for "Compact Disc @@ -82,7 +83,6 @@ config GDROM tristate "SEGA Dreamcast GD-ROM drive" depends on SH_DREAMCAST select CDROM - select BLK_SCSI_REQUEST # only for the generic cdrom code help A standard SEGA Dreamcast comes with a modified CD ROM drive called a "GD-ROM" by SEGA to signify it is capable of reading special disks @@ -360,7 +360,6 @@ config CDROM_PKTCDVD tristate "Packet writing on CD/DVD media (DEPRECATED)" depends on !UML select CDROM - select BLK_SCSI_REQUEST help Note: This driver is deprecated and will be removed from the kernel in the near future! -- 2.9.0