From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756746AbdKDNmw (ORCPT ); Sat, 4 Nov 2017 09:42:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60044 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbdKDNmv (ORCPT ); Sat, 4 Nov 2017 09:42:51 -0400 Date: Sat, 04 Nov 2017 22:42:39 +0900 (KST) Message-Id: <20171104.224239.229769899811546000.davem@davemloft.net> To: andreyknvl@google.com Cc: Dean_Jenkins@mentor.com, allan@asix.com.tw, peter.chen@nxp.com, tremyfr@gmail.com, gerg@linux-m68k.org, colin.king@canonical.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dvyukov@google.com, kcc@google.com Subject: Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend From: David Miller In-Reply-To: <9e768a837391af216cf1d2c8ac08af41f28cb147.1509654127.git.andreyknvl@google.com> References: <9e768a837391af216cf1d2c8ac08af41f28cb147.1509654127.git.andreyknvl@google.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 04 Nov 2017 06:42:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrey Konovalov Date: Thu, 2 Nov 2017 21:26:59 +0100 > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. ... > Signed-off-by: Andrey Konovalov Applied, thank you.