From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756345AbdKCTej (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 15:34:39 -0400
Received: from mail.kernel.org ([198.145.29.99]:47326 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751957AbdKCTei (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 15:34:38 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BD3621875
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org
Date: Sat, 4 Nov 2017 04:34:33 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: shuah@kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Rajvi Jingar <rajvi.jingar@intel.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail
Message-Id: <20171104043433.d3a9212548d5c5e2f1ffe4fc@kernel.org>
In-Reply-To: <02195d89-7999-0983-52bf-a0d222e69b38@kernel.org>
References: <150946150188.23534.2733334352688090372.stgit@devbox>
        <20171031174432.770bd509@gandalf.local.home>
        <20171101132340.f700f0081419897798a4b1f3@kernel.org>
        <02195d89-7999-0983-52bf-a0d222e69b38@kernel.org>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 1 Nov 2017 15:18:41 -0600
Shuah Khan <shuah@kernel.org> wrote:

> On 10/31/2017 10:23 PM, Masami Hiramatsu wrote:
> > On Tue, 31 Oct 2017 17:44:32 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> >> On Tue, 31 Oct 2017 23:51:42 +0900
> >> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >>
> >>> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> index 74507db8bbc8..b8701fa0b8f2 100644
> >>> --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> @@ -8,7 +8,7 @@ echo > kprobe_events
> >>>  echo p:myevent _do_fork > kprobe_events
> >>>  test -d events/kprobes/myevent
> >>>  echo 1 > events/kprobes/myevent/enable
> >>> -echo > kprobe_events && exit 1 # this must fail
> >>> +echo > kprobe_events && exit_fail
> >>
> >> Should we keep the comment about "this must fail", otherwise it may
> >> look like a mistake. Echoing in kprobe_events returns failure here?
> > 
> > Ah, good catch! I misread the comment is for "exit 1"...
> > 
> > Thank you,
> > 
> >>
> >> -- Steve
> >>
> >>
> >>>  echo 0 > events/kprobes/myevent/enable
> >>>  echo > kprobe_events # this must succeed
> >>>  clear_trace
> > 
> > 
> 
> Hi Masami,
> 
> Thanks Steve for the catch. I will wait for v2 then.

Sorry for later, I'll send it soon.

Thank you,

> 
> thanks,
> -- Shuah
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>