From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752352AbdKCUVa (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 16:21:30 -0400
Received: from mail.kernel.org ([198.145.29.99]:50818 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750772AbdKCUV2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 16:21:28 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23840218D2
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org
Date: Sat, 4 Nov 2017 05:21:25 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Rajvi Jingar <rajvi.jingar@intel.com>
Subject: Re: [PATCH v2] selftests/ftrace: Introduce exit_pass and exit_fail
Message-Id: <20171104052125.ef2662cf9366b3e131649281@kernel.org>
In-Reply-To: <20171103161109.7848f3c3@vmware.local.home>
References: <150973792087.3711.441163463778665781.stgit@devbox>
        <20171103161109.7848f3c3@vmware.local.home>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 3 Nov 2017 16:11:09 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat,  4 Nov 2017 04:38:41 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -222,7 +222,14 @@ SIG_RESULT=
> >  SIG_BASE=36	# Use realtime signals
> >  SIG_PID=$$
> >  
> > +exit_pass () {
> > +  exit 0
> > +}
> > +
> >  SIG_FAIL=$((SIG_BASE + FAIL))
> > +exit_fail () {
> > +  exit 1
> 
> Sorry, I should have caught this before. But can you use $PASS and
> $FAIL in the functions? In case we want to override them in the future?

No, as I've said, those are ftracetest internal vars :(

And also you can not override it because each testcase script can
exit with error code of executed command in failure case. IOW,
the error code propagates caller's exit code. So we can not
controll it. This means you can just expect the exit code
0 or !0.

Thank you,

> 
> exit_pass() {
> 	exit $PASS
> }
> 
> exit_fail() {
> 	exit $FAIL
> }
> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@kernel.org>