From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdKENNy (ORCPT ); Sun, 5 Nov 2017 08:13:54 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:45948 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbdKENNx (ORCPT ); Sun, 5 Nov 2017 08:13:53 -0500 Date: Sun, 05 Nov 2017 22:13:45 +0900 (KST) Message-Id: <20171105.221345.1891928990032403626.davem@davemloft.net> To: arnd@arndb.de Cc: madalin.bucur@nxp.com, jiri@mellanox.com, jhs@mojatatu.com, camelia.groza@nxp.com, Linyu.Yuan@alcatel-sbell.com.cn, claudiu.manoil@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dpaa_eth: avoid uninitialized variable false-positive warning From: David Miller In-Reply-To: <20171103125256.1829830-1-arnd@arndb.de> References: <20171103125256.1829830-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 05 Nov 2017 05:13:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 3 Nov 2017 13:52:24 +0100 > We can now build this driver on ARM, so I ran into a randconfig build > warning that presumably had existed on powerpc already. > > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function 'sg_fd_to_skb': > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1712:18: error: 'skb' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > I'm slightly changing the logic here, to make it obvious to the > compiler that 'skb' is always initialized. > > Signed-off-by: Arnd Bergmann Applied, thanks.