From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbdKEHbL (ORCPT ); Sun, 5 Nov 2017 02:31:11 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60917 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdKEHbI (ORCPT ); Sun, 5 Nov 2017 02:31:08 -0500 X-ME-Sender: Date: Sun, 5 Nov 2017 08:31:21 +0100 From: Greg KH To: Aleksa Sarai Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Valentin Rothberg , cyphar@cyphar.com, stable@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface Message-ID: <20171105073121.GB1431@kroah.com> References: <20171105025635.10843-1-asarai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171105025635.10843-1-asarai@suse.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 05, 2017 at 01:56:35PM +1100, Aleksa Sarai wrote: > Previously, the only capability effectively required to operate on the > /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, > having an fsuid of GLOBAL_ROOT_UID was enough). This means that > semi-privileged processes could interfere with core components of a > system (such as causing a DoS by removing the underlying SCSI device of > the host's / mount). Given that the previous patch didn't even compile, I worry that you have not tested this at all to see what breaks/changes in userspace with this type of user-visable api change. What did you do to test this? thanks, greg k-h