From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751954AbdKEJcO (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Nov 2017 04:32:14 -0500
Received: from mail-wr0-f182.google.com ([209.85.128.182]:55934 "EHLO
        mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750785AbdKEJcM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Nov 2017 04:32:12 -0500
X-Google-Smtp-Source: ABhQp+S6F1TrJNmwXPpmDFaSmu5zdASRg/67OyGIg94I9LJRzsrfijQEP89r3xOy844jAwJo0cuINA==
Date: Sun, 5 Nov 2017 10:32:08 +0100
From: Ingo Molnar <mingo@kernel.org>
To: changbin.du@intel.com
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com
Subject: Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation
 commands to standalone script
Message-ID: <20171105093208.5ncgz4o4klv3f3xn@gmail.com>
References: <1509873493-17929-1-git-send-email-changbin.du@intel.com>
 <1509873493-17929-2-git-send-email-changbin.du@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1509873493-17929-2-git-send-email-changbin.du@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


A few spelling fixes:

in the title:

s/Fact out
 /Factor out

* changbin.du@intel.com <changbin.du@intel.com> wrote:

> From: Changbin Du <changbin.du@intel.com>
> 
> The build message for fdimage/isoimage are pretty unstructured. The raw
> shell command blocks are printed. We can improve them as regular build
> system messages. Besides, writing commands in shell script is much more
> easier than in a Makefile.

s/much more easier
 /much more easy

> 
> See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124.
> 
> This patch fact out the commands used for fdimage/isoimage generation from
> arch/x86/boot/Makefile to new script arch/x86/boot/genimage.sh. Then add a
> new kbuild command 'genimage' which invokes the new script. All
> fdimages/isoimage now is generated by call to 'genimage' with different
> parameters.

s/fact out
 /factors out

s/to new script
  to a new script

s/Then add
 /Then it adds

s/a new kbuild command 'genimage'
 /the new 'genimage' kbuild command

s/All fdimages/isoimage now is generated by call to
 /All fdimage/isoimage files are now generated by a call to

> +#   $3 - kernel bzImage file
> +#   $4 - mtool configuration file
> +#   $5 - kernel cmdline
> +#   $6 - inird image file
> +#

The new script is much easier to read!

Thanks,

	Ingo