From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbdKEJd6 (ORCPT ); Sun, 5 Nov 2017 04:33:58 -0500 Received: from mail-wr0-f176.google.com ([209.85.128.176]:48846 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdKEJd4 (ORCPT ); Sun, 5 Nov 2017 04:33:56 -0500 X-Google-Smtp-Source: ABhQp+T9vWKaiXMGOMiHE25mKkvYCCK0vpVp1opi+r0qhOzRZ+TFsgCtHPWr5wdWMW+JvyePZACxXw== Date: Sun, 5 Nov 2017 10:33:53 +0100 From: Ingo Molnar To: changbin.du@intel.com Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32 Message-ID: <20171105093352.okrgv3623wsjwwin@gmail.com> References: <1509873493-17929-1-git-send-email-changbin.du@intel.com> <1509873493-17929-3-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509873493-17929-3-git-send-email-changbin.du@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * changbin.du@intel.com wrote: > From: Changbin Du > > Recently I failed to build isoimage target, because the path of isolinux.bin > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32. > > This patch has a improvement of the file search: > - Show a error message instead of silent fail. > - Add above new paths. How about: This patch improves the file search logic: - Show an error message instead of failing silently - Add the new paths listed above. > + if [ $i = end -a -z "$isolinux" ] ; then > + echo 'Need isolinux.bin, please install syslinux/isolinux' How about: echo 'Need an isolinux.bin file, please install syslinux/isolinux' Thanks, Ingo