From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdKEJh5 (ORCPT ); Sun, 5 Nov 2017 04:37:57 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:48460 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdKEJh4 (ORCPT ); Sun, 5 Nov 2017 04:37:56 -0500 X-Google-Smtp-Source: ABhQp+QKKiIfGmCmg9+6wYub5VDj5qIugnqRF55Kj2jj/qyjIPpgMUdM0aJRkwQ1QoBLW1I6jKTraw== Date: Sun, 5 Nov 2017 10:37:52 +0100 From: Ingo Molnar To: changbin.du@intel.com Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, Michal Marek Subject: Re: [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage generation Message-ID: <20171105093752.6e5hj777jbg7rr2b@gmail.com> References: <1509873493-17929-1-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509873493-17929-1-git-send-email-changbin.du@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * changbin.du@intel.com wrote: > From: Changbin Du > > This serias is a expansion of below original patch after discussion with Ingo > and Yamada. > [PATCH] x86, build: Improve the isolinux searching of isoimage generation > > Changbin Du (4): > x86, build: Fact out fdimage/isoimage generation commands to > standalone script > x86, build: Add new paths for isolinux.bin and ldlinux.c32 > x86, build: Specify -input-charset=utf-8 for mkisofs > x86, boot: Add some generated files to the .gitignore file > > arch/x86/boot/.gitignore | 3 ++ > arch/x86/boot/Makefile | 59 +++++------------------ > arch/x86/boot/genimage.sh | 119 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 133 insertions(+), 48 deletions(-) > create mode 100644 arch/x86/boot/genimage.sh Very nice - it looks good to me with the edits I suggested. Would be nice if the kbuild maintainers could take a look as well - is this how boot image construction should be done at the arch level? Thanks, Ingo