From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751306AbdKEPMi (ORCPT ); Sun, 5 Nov 2017 10:12:38 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:44668 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdKEPMg (ORCPT ); Sun, 5 Nov 2017 10:12:36 -0500 X-Google-Smtp-Source: ABhQp+Qlao/0sGAo70r0YrSq8dtNsL+hQJaPmQYD4X2nNw8bJtCrBhgy1Os/ZdPnN8Pdm8l44euMnw== Date: Sun, 5 Nov 2017 07:12:35 -0800 From: Guenter Roeck To: "Gustavo A. R. Silva" Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: watchdog: watchdog_dev: mark expected switch fall-through Message-ID: <20171105151235.GA27007@roeck-us.net> References: <20171103230327.GA4635@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103230327.GA4635@embeddedor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 06:03:27PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Guenter Roeck > --- > drivers/watchdog/watchdog_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c > index 1e971a5..a79ad5b 100644 > --- a/drivers/watchdog/watchdog_dev.c > +++ b/drivers/watchdog/watchdog_dev.c > @@ -720,7 +720,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd, > err = watchdog_ping(wdd); > if (err < 0) > break; > - /* Fall */ > + /* fall through */ > case WDIOC_GETTIMEOUT: > /* timeout == 0 means that we don't know the timeout */ > if (wdd->timeout == 0) {