From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbdKFIxz (ORCPT ); Mon, 6 Nov 2017 03:53:55 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25858 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdKFIxx (ORCPT ); Mon, 6 Nov 2017 03:53:53 -0500 Date: Mon, 6 Nov 2017 11:53:29 +0300 From: Dan Carpenter To: Nicolas Ferre Cc: SF Markus Elfring , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() Message-ID: <20171106085329.szz2ocu5d2iurlov@mwanda> References: <2db677d2-ad4e-1f79-344b-dfa38ce948c9@users.sourceforge.net> <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 09:40:19AM +0100, Nicolas Ferre wrote: > If you want to lower the size of strings in this driver, you can do it, > but not like this. Just so we're clear, GCC already detects and combines it when you use the same string constant twice. regards, dan carpenter