From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752576AbdKFJZj (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 04:25:39 -0500
Received: from mga06.intel.com ([134.134.136.31]:10735 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752531AbdKFJZc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 04:25:32 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,351,1505804400"; 
   d="scan'208";a="1214705621"
Date: Mon, 6 Nov 2017 11:18:55 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] thunderbolt: tb: fix use after free in
 tb_activate_pcie_devices
Message-ID: <20171106091855.GQ2283@lahna.fi.intel.com>
References: <20171105045254.GA13399@embeddedor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20171105045254.GA13399@embeddedor.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 04, 2017 at 11:52:54PM -0500, Gustavo A. R. Silva wrote:
> Add a ̣̣continue statement in order to avoid using a previously
> free'd pointer tunnel in list_add.
> 
> Addresses-Coverity-ID: 1415336
> Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection manager")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Good catch!

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Greg, can you pick this to your char-misc tree? Thanks.

> ---
>  drivers/thunderbolt/tb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
> index d674e06..1424581 100644
> --- a/drivers/thunderbolt/tb.c
> +++ b/drivers/thunderbolt/tb.c
> @@ -225,6 +225,7 @@ static void tb_activate_pcie_devices(struct tb *tb)
>  			tb_port_info(up_port,
>  				     "PCIe tunnel activation failed, aborting\n");
>  			tb_pci_free(tunnel);
> +			continue;
>  		}
>  
>  		list_add(&tunnel->list, &tcm->tunnel_list);
> -- 
> 2.7.4