From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbdKFJyL (ORCPT ); Mon, 6 Nov 2017 04:54:11 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:46449 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbdKFJyI (ORCPT ); Mon, 6 Nov 2017 04:54:08 -0500 Date: Mon, 6 Nov 2017 12:53:45 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Ferre , Bartlomiej Zolnierkiewicz , LKML , kernel-janitors@vger.kernel.org Subject: Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() Message-ID: <20171106095345.ds5ftmdmq4xjnadg@mwanda> References: <2db677d2-ad4e-1f79-344b-dfa38ce948c9@users.sourceforge.net> <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> <20171106085329.szz2ocu5d2iurlov@mwanda> <5e11db02-618e-ac60-921f-2971458a4484@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e11db02-618e-ac60-921f-2971458a4484@users.sourceforge.net> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote: > >> If you want to lower the size of strings in this driver, you can do it, > >> but not like this. > > > > Just so we're clear, GCC already detects and combines it when you use > > the same string constant twice. > > Do you distinguish between merging of constants and the combination > of statements for such an use case? I would have rejected the patch even if GCC didn't combine the strings because the most important thing is that the code is readable. regards, dan carpenter