From: Himanshu Jha <himanshujha199640@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org
Subject: Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
Date: Mon, 6 Nov 2017 16:57:09 +0530 [thread overview]
Message-ID: <20171106112709.GA4822@himanshu-Vostro-3559> (raw)
In-Reply-To: <20171104220256.GA7012@amd>
On Sat, Nov 04, 2017 at 11:02:56PM +0100, Pavel Machek wrote:
> On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
>
> ACK.
>
> But note you have typo in the subject ;-).
Oops!
Do I need to send v2 with correct subject ?
> Plus this kind of bug is usually called thinko.
> Pavel
>
>
> > diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> > index 3995df1..21f5aa0 100644
> > --- a/include/linux/freezer.h
> > +++ b/include/linux/freezer.h
> > @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> > }
> >
> > /*
> > - * Like freezable_schedule_timeout(), but should not block the freezer. Do not
> > + * Like schedule_timeout(), but should not block the freezer. Do not
> > * call this with locks held.
> > */
> > static inline long freezable_schedule_timeout(long timeout)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Thanks
Himanshu Jha
next prev parent reply other threads:[~2017-11-06 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 21:57 Himanshu Jha
2017-11-04 22:02 ` Pavel Machek
2017-11-06 11:27 ` Himanshu Jha [this message]
2017-11-06 11:38 ` Pavel Machek
2017-11-07 19:52 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106112709.GA4822@himanshu-Vostro-3559 \
--to=himanshujha199640@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®