From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdKFMNQ (ORCPT ); Mon, 6 Nov 2017 07:13:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:58739 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdKFMNP (ORCPT ); Mon, 6 Nov 2017 07:13:15 -0500 Date: Mon, 6 Nov 2017 13:13:13 +0100 From: Petr Mladek To: "Liu, Changcheng" Cc: Sergey Senozhatsky , jpoimboe@redhat.com, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0001/0001] format idle IP output func+offset/length Message-ID: <20171106121313.GA2652@pathway.suse.cz> References: <20171106031930.GA69070@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106031930.GA69070@sofia> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2017-11-06 11:19:31, Liu, Changcheng wrote: > kaslr feature is enabled in kernel. > Remove kernel text address when dumping idle IP info > diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c > index 0bc0a35..9cc4178 100644 > --- a/lib/nmi_backtrace.c > +++ b/lib/nmi_backtrace.c > @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) > if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { > arch_spin_lock(&lock); > if (regs && cpu_in_idle(instruction_pointer(regs))) { > - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", > + pr_warn("NMI backtrace for cpu %d skipped: idling at pc %pS\n", Great catch! Reviewed-by: Petr Mladek Best Regards, Petr