From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbdKFNLu (ORCPT ); Mon, 6 Nov 2017 08:11:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbdKFNLt (ORCPT ); Mon, 6 Nov 2017 08:11:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6337849025 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Mon, 6 Nov 2017 07:11:47 -0600 From: Josh Poimboeuf To: "Liu, Changcheng" Cc: Sergey Senozhatsky , Petr Mladek , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0001/0001] format idle IP output func+offset/length Message-ID: <20171106131147.ouihd4ug5ah3vb6a@treble> References: <20171106052511.GB69364@sofia> <20171106080528.GA1298@jagdpanzerIV> <20171106105203.GC69364@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171106105203.GC69364@sofia> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 06 Nov 2017 13:11:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 06:52:03PM +0800, Liu, Changcheng wrote: > kaslr feature is enabled in kernel. > Remove kernel text address when dumping idle IP info > > Signed-off-by: Liu Changcheng > Signed-off-by: Jerry Liu > > diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c > index 0bc0a35..9cc4178 100644 > --- a/lib/nmi_backtrace.c > +++ b/lib/nmi_backtrace.c > @@ -92,7 +92,7 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) > if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { > arch_spin_lock(&lock); > if (regs && cpu_in_idle(instruction_pointer(regs))) { > - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", > + pr_warn("NMI backtrace for cpu %d skipped: idling at %pS\n", > cpu, instruction_pointer(regs)); > } else { > pr_warn("NMI backtrace for cpu %d\n", cpu); 1) The patch introduces a compile warning. 2) When posting a new version of the patch, it should have a new version in the subject, e.g. "PATCH v2". 3) The subject is missing a prefix, like "lib_backtrace: " 4) The subject isn't very clear, how about something like: lib_backtrace: fix kernel text address leak 5) The description isn't correct. KASLR isn't always enabled, it depends on the user's config. But even without KASLR, we don't want to leak kernel text addresses. 6) The description should use complete sentences. 7) I'm not sure the "Signed-off-by:" chain is correct. Was Jerry Liu the original author of the patch? -- Josh