From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902AbdKFNcS (ORCPT ); Mon, 6 Nov 2017 08:32:18 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:50354 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbdKFNcR (ORCPT ); Mon, 6 Nov 2017 08:32:17 -0500 From: Arnd Bergmann To: Mark Brown , Vinod Koul , Guneshwor Singh Cc: Arnd Bergmann , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Naveen Manohar , "Subhransu S. Prusty" , Harsha Priya N , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: intel: initialize return value properly Date: Mon, 6 Nov 2017 14:30:36 +0100 Message-Id: <20171106133114.339667-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:GwUFKiakQGD7rW8DZjNfWJjJFWSrXEKHordrekoFwXiK7oRyVmF HANIiUKsRioDrEClG11rEGcb7bEhod8PyE8AGp9hDIA7QgvgP4ZjKQwi3OQlhV9qVvh+j3K D10xDDjgFUf8T6Aanegbi6Ezbu4rkIC0qY0+53ywyzoGaMplN+YzhXko0JnAzzGx+byXXF6 M1oLZvwyaNjM5/0Vk+XbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:U3FTiTRJ2N8=:x2e04Wu56dqNSCFDOLc/3O Iwyw1xXilEioIMYDIw1gWCQAOPKF1QLYJPbGLB4WcpZi2W7TzPQMqmfrZxT4+BOsoHN47dcy7 mKpI/3dHlCyk+JgQ+Icw0h5KtcjJa2qZohN5qRq2ykl/w4x0myPC/mWxB0Vwev9zDWEmzRDK6 eDZz1Zwsxo7lCnkIYDiOH3D9EY81ZPY7mhQfo3zfv7+uD6gvnXPDBmr+uhN1FdYajg74dw9SI vMgCLX9Q6IQgJ7CgD28KIvLNwGyR7EIfOtX2FP65oEQ5wQkD2OJmfKm5NFaptpudoObbOEj7x CoXY2zCT7/tVO6V0QoYHcNUS6CGJf70P32KHNLPay2i/FD1iN70WSBSIzUMmrXjQZC+ZayJ4x EjQJtP4vB2a4if84n4reIJaJzU7IT50d760UJkMX/f7xeZ3WRzRgp6/FDR6XUsgjNq1vJrLJN kCNs0SRxX21G/+AiE8KWpPmXqhBk0/F1JxGML6o0pyFk7tP9hEKND169sTM/z8ZJkXrkgawOA mltYZYaAni12ujMvAABz/NqV1xFqBJhz8IAsYXK+EYC5vtOP74rCmSn4EJAuHRq3s9CEz8oNy 3JmFkPNBySbeCg4qkIaLWHFSQJVs7R66TkWWz+xK5P3M5gGpTlIxSQ4SKrNSqNjjiTmn2ySI2 gCGYEmOgX5QF74W09z72z2vSCJvoDfay5f/exN1s9bI7HvnMKR7WbGaVQgrvuayVBas8rTTjs 3O+1pYeJ0Q+IUaUJYE1uAfcJ6eGWqMkDOFa2VA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_SND_SOC_HDAC_HDMI is disabled, we can run into an uninitialized variable: sound/soc/intel/skylake/skl.c: In function 'skl_resume': sound/soc/intel/skylake/skl.c:326:6: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] I have run into this on today's linux-next kernel, but it appears that this is an older problem that was just hard to trigger with randconfig builds as CONFIG_SND_SOC_HDAC_HDMI would in effect be impossible to disable when having SND_SOC_INTEL_SKYLAKE enabled. Signed-off-by: Arnd Bergmann --- sound/soc/intel/skylake/skl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 31d8634e8aa1..acb0ab470ca6 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -355,6 +355,7 @@ static int skl_resume(struct device *dev) if (ebus->cmd_dma_state) snd_hdac_bus_init_cmd_io(&ebus->bus); + ret = 0; } else { ret = _skl_resume(ebus); -- 2.9.0