From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932580AbdKFRWu (ORCPT ); Mon, 6 Nov 2017 12:22:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:50704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdKFRWt (ORCPT ); Mon, 6 Nov 2017 12:22:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A09218B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Mon, 6 Nov 2017 11:22:47 -0600 From: Bjorn Helgaas To: Keerthy Cc: Niklas Cassel , kishon@ti.com, bhelgaas@google.com, t-kristo@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v4] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks Message-ID: <20171106172247.GA31930@bhelgaas-glaptop.roam.corp.google.com> References: <1505885055-30657-1-git-send-email-j-keerthy@ti.com> <20171011193207.GO25517@bhelgaas-glaptop.roam.corp.google.com> <4ab0e697-b23b-0cc6-6ffa-8479e07c5aed@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ab0e697-b23b-0cc6-6ffa-8479e07c5aed@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 10:34:28AM +0530, Keerthy wrote: > > > On Friday 03 November 2017 08:00 PM, Niklas Cassel wrote: > > dra7xx_pcie_shutdown should be static. > > > > This patch introduces a new sparse warning. > > Thanks Niklas for reporting. > > Bjorn, > > Should i send a next version or just a fix patch on top of this? Either way is fine. I'll just fold it in or replace the existing patch. > > On Wed, Oct 11, 2017 at 9:32 PM, Bjorn Helgaas wrote: > >> On Wed, Sep 20, 2017 at 10:54:15AM +0530, Keerthy wrote: > >>> Add shutdown handler to cleanly turn off clocks. This will help > >>> in cases of kexec where in a new kernel can boot abruptly. > >>> > >>> Signed-off-by: Keerthy > >>> Acked-by: Kishon Vijay Abraham I > >> > >> Applied to pci/host-dra7xx for v4.15, thanks! > >> > >>> --- > >>> > >>> Changes in v4: > >>> > >>> * Added the missing changes from v2! > >>> > >>> Changes in v3: > >>> > >>> * Pushed the function outside #ifdef CONFIG_PM_SLEEP. > >>> * Added more details to commit log. > >>> > >>> Changes in v2: > >>> > >>> * used a local dev pointer instead of dereferencing dev at multiple places. > >>> * dra7xx_pcie_stop_link before disabling clks in the shutdown path. > >>> > >>> drivers/pci/dwc/pci-dra7xx.c | 17 +++++++++++++++++ > >>> 1 file changed, 17 insertions(+) > >>> > >>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c > >>> index 34427a6..d084800 100644 > >>> --- a/drivers/pci/dwc/pci-dra7xx.c > >>> +++ b/drivers/pci/dwc/pci-dra7xx.c > >>> @@ -794,6 +794,22 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) > >>> } > >>> #endif > >>> > >>> +void dra7xx_pcie_shutdown(struct platform_device *pdev) > >>> +{ > >>> + struct device *dev = &pdev->dev; > >>> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev); > >>> + int ret; > >>> + > >>> + dra7xx_pcie_stop_link(dra7xx->pci); > >>> + > >>> + ret = pm_runtime_put_sync(dev); > >>> + if (ret < 0) > >>> + dev_dbg(dev, "pm_runtime_put_sync failed\n"); > >>> + > >>> + pm_runtime_disable(dev); > >>> + dra7xx_pcie_disable_phy(dra7xx); > >>> +} > >>> + > >>> static const struct dev_pm_ops dra7xx_pcie_pm_ops = { > >>> SET_SYSTEM_SLEEP_PM_OPS(dra7xx_pcie_suspend, dra7xx_pcie_resume) > >>> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(dra7xx_pcie_suspend_noirq, > >>> @@ -807,5 +823,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) > >>> .suppress_bind_attrs = true, > >>> .pm = &dra7xx_pcie_pm_ops, > >>> }, > >>> + .shutdown = dra7xx_pcie_shutdown, > >>> }; > >>> builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe); > >>> -- > >>> 1.9.1 > >>>