From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbdKFRgm (ORCPT ); Mon, 6 Nov 2017 12:36:42 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:33295 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbdKFRgk (ORCPT ); Mon, 6 Nov 2017 12:36:40 -0500 Date: Mon, 6 Nov 2017 09:36:25 -0800 From: Christoph Hellwig To: Peter Zijlstra Cc: Dmitry Vyukov , Al Viro , Jan Kara , syzbot , Andrew Morton , Johannes Weiner , jlayton@redhat.com, LKML , linux-mm@kvack.org, npiggin@gmail.com, rgoldwyn@suse.com, ross.zwisler@linux.intel.com, syzkaller-bugs@googlegroups.com, Ingo Molnar Subject: Re: possible deadlock in generic_file_write_iter Message-ID: <20171106173625.GA1058@infradead.org> References: <94eb2c05f6a018dc21055d39c05b@google.com> <20171106032941.GR21978@ZenIV.linux.org.uk> <20171106131544.GB4359@quack2.suse.cz> <20171106133304.GS21978@ZenIV.linux.org.uk> <20171106160107.GA20227@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106160107.GA20227@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org How about complete_nodep() as name? Otherwise this looks ok to me - not pretty, but not _that_ horrible either..