From: Wolfram Sang <wsa@the-dreams.de>
To: Joel Stanley <joel@jms.id.au>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Jeffery <andrew@aj.id.au>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: aspeed: Deassert reset in probe
Date: Mon, 6 Nov 2017 19:23:18 +0100 [thread overview]
Message-ID: <20171106182318.xk2rkz7vv2p3sqso@ninjato> (raw)
In-Reply-To: <20171101002330.24981-1-joel@jms.id.au>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Wed, Nov 01, 2017 at 10:53:30AM +1030, Joel Stanley wrote:
> In order to use i2c from a cold boot, the i2c peripheral must be taken
> out of reset. We request a shared reset controller each time a bus
> driver is loaded, as the reset is shared between the 14 i2c buses.
>
> On remove the reset is asserted, which only touches the hardware once
> the last i2c bus is removed.
>
> The reset is required as the I2C buses will not work without releasing
> the reset. Previously the driver only worked with out of tree hacks
> that released this reset before the driver was loaded. Update the
> device tree bindings to reflect this.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Applied to for-next, thanks and thanks for the ack, Rob!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-06 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 0:23 Joel Stanley
2017-11-05 12:49 ` Wolfram Sang
2017-11-06 1:40 ` Joel Stanley
2017-11-06 14:19 ` Rob Herring
2017-11-06 18:23 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106182318.xk2rkz7vv2p3sqso@ninjato \
--to=wsa@the-dreams.de \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®