From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbdKFVZW (ORCPT ); Mon, 6 Nov 2017 16:25:22 -0500 Received: from mga03.intel.com ([134.134.136.65]:27918 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbdKFVZU (ORCPT ); Mon, 6 Nov 2017 16:25:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,354,1505804400"; d="scan'208";a="172756097" Date: Mon, 6 Nov 2017 13:25:19 -0800 From: Andi Kleen To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, kan.liang@intel.com, jolsa@redhat.com Subject: Re: [PATCH v2 4/5] perf/record: add support for sampling skid ip Message-ID: <20171106212519.GC5320@tassilo.jf.intel.com> References: <1509646559-919-1-git-send-email-eranian@google.com> <1509646559-919-5-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509646559-919-5-git-send-email-eranian@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2017 at 11:15:58AM -0700, Stephane Eranian wrote: > This patch adds a new --skid-ip option to perf record > to capture the unmodified interrupted instruction pointer in > each sample. With this option, the kernel captures both the > ip and skid ip. Unless precise mode is enabled both ip are > the same. They may be different in precise mode depending > on the event and precise sampling mode. > > $ perf record --skid-ip ..... perf record already has too many options. I would rather just make it a event qualifier which is more flexible too perf record -e cpu/cpu-cycles,skidip=1/ -Andi