From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634AbdKGLM4 (ORCPT ); Tue, 7 Nov 2017 06:12:56 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:46083 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932436AbdKGLMz (ORCPT ); Tue, 7 Nov 2017 06:12:55 -0500 X-Google-Smtp-Source: ABhQp+SkisAtpNY9VLiE5XoTuelkUJ4eQNGAaDU+vOY1zR8rbqV1BFcqTCfRVrLAtn6rSiepjMT1NQ== Date: Tue, 7 Nov 2017 12:12:51 +0100 From: Ingo Molnar To: "Du, Changbin" Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com Subject: Re: [PATCH v2 1/4] x86, build: Factor out fdimage/isoimage generation commands to standalone script Message-ID: <20171107111251.zc4qu2vvlu5igeoe@gmail.com> References: <1509939179-7556-1-git-send-email-changbin.du@intel.com> <1509939179-7556-2-git-send-email-changbin.du@intel.com> <20171107102029.4zvhovgdguthyg6u@gmail.com> <20171107103524.GA16764@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171107103524.GA16764@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Du, Changbin wrote: > On Tue, Nov 07, 2017 at 11:20:29AM +0100, Ingo Molnar wrote: > > > > * changbin.du@intel.com wrote: > > > > > From: Changbin Du > > > > > > The build message for fdimage/isoimage are pretty unstructured. The raw > > > shell command blocks are printed. We can improve them as regular build > > > system messages. Besides, writing commands in a shell script is much more > > > easy than in a Makefile. > > > > > > See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124. > > > > > > This patch factors out the commands used for fdimage/isoimage generation > > > from arch/x86/boot/Makefile to a new script arch/x86/boot/genimage.sh. > > > Then it adds the new kbuild command 'genimage' which invokes the new script. > > > All fdimages/isoimage files are now generated by a call to 'genimage' with > > > different parameters. > > > > > > Now 'make isoimage' becomes: > > > ... > > > Kernel: arch/x86/boot/bzImage is ready (#30) > > > GENIMAGE arch/x86/boot/image.iso > > > Size of boot image is 4 sectors -> No emulation > > > 15.37% done, estimate finish Sun Nov 5 23:36:57 2017 > > > 30.68% done, estimate finish Sun Nov 5 23:36:57 2017 > > > 46.04% done, estimate finish Sun Nov 5 23:36:57 2017 > > > 61.35% done, estimate finish Sun Nov 5 23:36:57 2017 > > > 76.69% done, estimate finish Sun Nov 5 23:36:57 2017 > > > 92.00% done, estimate finish Sun Nov 5 23:36:57 2017 > > > Total translation table size: 2048 > > > Total rockridge attributes bytes: 659 > > > Total directory bytes: 0 > > > Path table size(bytes): 10 > > > Max brk space used 0 > > > 32608 extents written (63 MB) > > > Kernel: arch/x86/boot/image.iso is ready > > > > Could we please also do another patch, to make it emit only this by default: > > > > > GENIMAGE arch/x86/boot/image.iso > > > > None of the other messages really matter to the user. > > > > Maybe emit them when building with V=1 - but none of that info is really > > interesting IMHO. > > > Ingo, do you mean that omit below messages? > Size of boot image is 4 sectors -> No emulation > 15.37% done, estimate finish Sun Nov 5 23:36:57 2017 > ... > 32608 extents written (63 MB) Yes, and all the other unnecessary verbosity. > These are printed by mkisofs. How about just add '-quite' parameter to it? Yes, or redirect it to /dev/null or any other solution. Thanks, Ingo